Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Post Module support #71

Open
4 tasks
quasel opened this issue Jun 19, 2018 · 1 comment
Open
4 tasks

Improve Post Module support #71

quasel opened this issue Jun 19, 2018 · 1 comment
Assignees

Comments

@quasel
Copy link
Member

quasel commented Jun 19, 2018

  • maybe switch the filter for altering the query
  • make custom post module aware of "context" if possible
  • dig into custom where options like widget/shortcode
  • support Taxonomy Filters by setting post_type (Settings UI or Code)

Take a look at
PP: Timeline, Content Tiles, ...

Started discussion with the BB/UABB/PP Team how to improve the loop-settings.php
To avoid stuff like:

// add additional pods settings to any posts module
	add_action( 'fl_builder_loop_settings_before_form', 'pods_beaver_loop_settings_before_form', 10, 1 );
	add_action( 'uabb_loop_settings_before_form', 'pods_beaver_loop_settings_before_form', 10, 1 );
	add_action( 'pp_cg_loop_settings_before_form', 'pods_beaver_loop_settings_before_form', 10, 1 );
	add_action( 'pp_ct_loop_settings_before_form', 'pods_beaver_loop_settings_before_form', 10, 1 );

@taxonomy Filters:
might need JS - trigger when any "pick" Type Field is selected and set the post_type, maybe needs data_source to be triggerd to to get other settings to update!

Seem PP only alllows Taxonomy Filters for - custom_query (mail sent)

if ( $( '.fl-builder-pp-content-grid-settings select[name="data_source"]' ).val() !== 'custom_query' ) {
	return;
}
@quasel
Copy link
Member Author

quasel commented Jun 20, 2018

Be Aware of uabb_loop_query_args() as UABB enforces the PostType

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant