Skip to content

fix(Data/PostgreSQL): PostgreSQL reconnect() doesn't restore session … #5027

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(Data/PostgreSQL): PostgreSQL reconnect() doesn't restore session … #5027

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions Data/PostgreSQL/src/SessionHandle.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,6 +78,9 @@ void SessionHandle::connect(const std::string& aConnectionString)
{
Poco::FastMutex::ScopedLock mutexLocker(_sessionMutex);

_inTransaction = false;
_preparedStatementsToBeDeallocated.clear();

if (isConnectedNoLock())
{
throw ConnectionFailedException("Already Connected");
Expand Down
33 changes: 33 additions & 0 deletions Data/PostgreSQL/testsuite/src/PostgreSQLTest.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,7 @@
#include "Poco/Data/DataException.h"
#include <iostream>

#include "Poco/Data/Transaction.h"

using namespace Poco::Data;
using namespace Poco::Data::Keywords;
Expand Down Expand Up @@ -794,6 +795,37 @@ void PostgreSQLTest::testReconnect()
}


void PostgreSQLTest::testTransactionWithReconnect()
{
if (!_pSession) fail ("Test not available.");

try
{
_pSession->begin();
*_pSession << "CREATE TABLE Person (LastName VARCHAR(30), FirstName VARCHAR(30), Address VARCHAR(30), Age INTEGER)", now;
_pSession->reconnect();
_pSession->commit();
}
catch (Poco::Exception& e)
{
_pSession->rollback();
std::cout << e.displayText() << std::endl;
}

try
{
_pSession->begin();
*_pSession << "CREATE TABLE Person (LastName VARCHAR(30), FirstName VARCHAR(30), Address VARCHAR(30), Age INTEGER)", now;
_pSession->commit();
}
catch (Poco::Exception& e)
{
_pSession->rollback();
std::cout << e.displayText() << std::endl;
}
}


void PostgreSQLTest::testSqlState()
{
if (!_pSession) fail ("Test not available.");
Expand Down Expand Up @@ -1333,6 +1365,7 @@ CppUnit::Test* PostgreSQLTest::suite()
CppUnit_addTest(pSuite, PostgreSQLTest, testSessionTransactionNoAutoCommit);
CppUnit_addTest(pSuite, PostgreSQLTest, testTransaction);
CppUnit_addTest(pSuite, PostgreSQLTest, testReconnect);
CppUnit_addTest(pSuite, PostgreSQLTest, testTransactionWithReconnect);

return pSuite;
}
2 changes: 1 addition & 1 deletion Data/PostgreSQL/testsuite/src/PostgreSQLTest.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -113,7 +113,7 @@ class PostgreSQLTest: public CppUnit::TestCase
void testSessionTransactionNoAutoCommit();
void testTransaction();
void testReconnect();

void testTransactionWithReconnect();
void testSqlState();

void setUp();
Expand Down
Loading