Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PocoFoundationConfig.cmake is missing Utf8Proc dependency #4798

Open
atsampson opened this issue Dec 2, 2024 · 0 comments · Fixed by #4816
Open

PocoFoundationConfig.cmake is missing Utf8Proc dependency #4798

atsampson opened this issue Dec 2, 2024 · 0 comments · Fixed by #4816
Assignees
Labels
bug cmake Related to cmake build system fixed

Comments

@atsampson
Copy link

Describe the bug
Poco 1.14.0 introduced a dependency on Utf8Proc. However, PocoFoundationConfig.cmake doesn't have a find_dependency call for it.

To Reproduce
Install Poco 1.14.0 with -DPOCO_UNBUNDLED on Linux. Attempt to configure Mumble 1.5.634 against it (Mumble's CMake build system doesn't look for Utf8Proc itself). CMake fails, with the error:

  The link interface of target "Poco::Foundation" contains:
                                  
    Utf8Proc::Utf8Proc

  but the target was not found.  [...]

Expected behavior
Configuration completes as with previous versions of Poco (although I expect Mumble will need other fixes too).

Please add relevant environment information:

  • Linux (GARStow)
  • POCO 1.14.0
  • CMake 3.31.1

Additional context
I've fixed this locally by adding cmake/FindUtf8Proc.cmake to the installation of FindPCRE2.cmake in CMakeLists.txt, and adding find_dependency(Utf8Proc REQUIRED) to cmake/PocoFoundationConfig.cmake; I'm not sure if that's the right fix, but it's consistent with how the other dependencies are handled.

@atsampson atsampson added the bug label Dec 2, 2024
@obiltschnig obiltschnig self-assigned this Dec 2, 2024
@obiltschnig obiltschnig added this to the Release 1.14.1 milestone Dec 2, 2024
@matejk matejk added this to 1.14 Dec 6, 2024
@matejk matejk self-assigned this Dec 9, 2024
@matejk matejk moved this to In Progress in 1.14 Dec 9, 2024
@matejk matejk added the cmake Related to cmake build system label Dec 11, 2024
@matejk matejk closed this as completed in b380b57 Dec 11, 2024
@matejk matejk added the fixed label Dec 11, 2024
@matejk matejk reopened this Dec 11, 2024
matejk added a commit that referenced this issue Dec 11, 2024
…4816)

* fix(cmake): Add missing install and find dependency for utf8proc in unbundled build.

* chore(gitignore): Corrected path to Qt creator generated build files.
@matejk matejk moved this from In Progress to Done in 1.14 Dec 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug cmake Related to cmake build system fixed
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

3 participants