Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Built-in toggle? #9

Open
xfzv opened this issue Sep 12, 2023 · 3 comments
Open

Built-in toggle? #9

xfzv opened this issue Sep 12, 2023 · 3 comments

Comments

@xfzv
Copy link

xfzv commented Sep 12, 2023

Sometimes I'd like to watch the chapters I usually skip, so I'm using this to quickly toggle the plug-in:

  • mpv.conf
[po5-chapter-skip-disabled]
profile-desc="Disable po5/chapterskip"
profile-restore=copy
script-opts=chapterskip-skip=""
  • input.conf
C    script-message cycle-commands "apply-profile po5-chapter-skip-disabled ; show-text `'po5/chapterskip disabled'`" "apply-profile po5-chapter-skip-disabled restore ; show-text `'po5/chapterskip enabled'`"    #! Chapters > Toggle po5/chapterskip

Works just fine. It would be nice if there was a built-in toggle instead of relying on an mpv profile.

In case you don't want to implement this, maybe this could be added to the README. Unless there's a better way, of course.

Thoughts?

@po5
Copy link
Owner

po5 commented Sep 13, 2023

How do you expect this to work? Should it disable chapterskip for the current file, until you turn it back on?

@xfzv
Copy link
Author

xfzv commented Sep 13, 2023

Should it disable chapterskip for the current file, until you turn it back on?

With my current method involving the mpv profile, chapterskip remains disabled when I go to the previous/next file in the playlist until I enable it again with C.

I'm fine with this behavior, but I wouldn't mind if it was only for the current file (and enable it again when going to previous/next file?).

Maybe there are good reasons to prefer this over permanent toggle for the whole "mpv session", I have no opinion on this specifically.

@xfzv
Copy link
Author

xfzv commented Sep 26, 2023

Eisa01/SmartSkip has this (1 ; 2). The toggle affects the whole mpv session, not just the current file.

The countdown option which allows to cancel the skip with a keybinding is nice too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants