Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use tokio::fs for all filesystem operations #94

Open
KSXGitHub opened this issue Aug 26, 2023 · 2 comments
Open

use tokio::fs for all filesystem operations #94

KSXGitHub opened this issue Aug 26, 2023 · 2 comments

Comments

@KSXGitHub
Copy link
Contributor

https://docs.rs/tokio/latest/tokio/fs/index.html

@anonrig
Copy link
Member

anonrig commented Aug 26, 2023

I remember reading an article about tokio::fs is slower than std::fs. Ref: https://users.rust-lang.org/t/why-tokio-fs-is-slower-than-std-fs/39610

@KSXGitHub
Copy link
Contributor Author

I remember reading an article about tokio::fs is slower than std::fs. Ref: https://users.rust-lang.org/t/why-tokio-fs-is-slower-than-std-fs/39610

The async code in the link is slow is because there is no parallelization. The author called .await serially on each entry.

Again. As with all things, we need to benchmark to find out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants