Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Double cache retrieval in README #130

Closed
falko-apheris opened this issue Jun 19, 2024 · 1 comment · Fixed by #131
Closed

Double cache retrieval in README #130

falko-apheris opened this issue Jun 19, 2024 · 1 comment · Fixed by #131

Comments

@falko-apheris
Copy link

In the readme I see under "Use cache to reduce installation time"

- name: Install Node.js
        uses: actions/setup-node@v4
        with:
          node-version: 20
          cache: 'pnpm'

Which is caching pnpm install artifacts and restoring them again. But just below there is

- uses: actions/cache@v4
        name: Setup pnpm cache
        with:
          path: ${{ env.STORE_PATH }}
          key: ${{ runner.os }}-pnpm-store-${{ hashFiles('**/pnpm-lock.yaml') }}
          restore-keys: |
            ${{ runner.os }}-pnpm-store-

This seems like a duplication. I obsevered that the output of the ci pipleline indicates that both actions are writing to the same directory

@its-monotype
Copy link
Contributor

its-monotype commented Jun 20, 2024

Just noticed the same, after action runs it left two cache duplicates. Manual cache should be removed in favour of setup-node cache

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants