Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

💡 [Feature]: Sample gallery could have a filter by extension type when extension is selected #219

Closed
Adam-it opened this issue Apr 17, 2024 · 3 comments
Closed

💡 [Feature]: Sample gallery could have a filter by extension type when extension is selected #219

Adam-it opened this issue Apr 17, 2024 · 3 comments
Assignees
@nicodecleyre
Labels
⭐ enhancement New feature or request 👨‍💻work in progress I am working on it
Milestone
v3.X

Comments

@Adam-it
Copy link
Contributor

Adam-it commented Apr 17, 2024

🎯 Aim of the feature

We could extend the sample gallery with an additional filter option that should be visible only when the extension component type is selected. The new option should allow to filter by SPFx extension type.

📷 Images (if possible) with expected result

image

🤔 Additional remarks or comments

No response
@Adam-it Adam-it added ⭐ enhancement New feature or request 🙏 help wanted Open for contributors labels Apr 17, 2024
@Adam-it Adam-it added this to the v3.X milestone Apr 17, 2024
@nicodecleyre
Copy link
Contributor

Great addition @Adam-it 🙌

Can I work on it please? 😄

@Adam-it Adam-it added 👨‍💻work in progress I am working on it and removed 🙏 help wanted Open for contributors labels Jun 10, 2024
@Adam-it
Copy link
Contributor Author

Adam-it commented Jun 10, 2024

Yes please 🤩.
Please be sure to recheck the contributing notes before you start.
Please do not hesitate to ask any kind of question or share any kind of problem when implementing this feature, I am here to help 👍

Happy coding!

@nicodecleyre nicodecleyre mentioned this issue Jun 18, 2024
Merged
4 tasks
nicodecleyre added a commit to nicodecleyre/vscode-viva that referenced this issue Aug 8, 2024
@nicodecleyre
Merge branch 'Sample-gallery-with-extension-type-pnp#219' of https://…
1f4fb95 
…github.com/nicodecleyre/vscode-viva into Sample-gallery-with-extension-type-pnp#219
Adam-it pushed a commit that referenced this issue Aug 25, 2024
@nicodecleyre
Sample gallery with extension type, Closes #219 (#260)
11100a4 
## 🎯 Aim

Adding an extra filter to Sample gallery so that we can filter on the
extension type. Filter can only be visible when extension type is
selected 'Component Type'

## 📷 Result

![image](https://github.com/pnp/vscode-viva/assets/35696168/c8c2e084-5831-4fc4-861e-ad4c4c0845d7)

## ✅ What was done

- [X] Added Extension filter dropdown
- [X] Added functionality so that extension filter is only visible when
extension is selected in the Component Type dropdown
- [X] Added filter functionality so that samples get filtered based on
selected value in extension dropdown
- [x] Added filter functionality so that samples don't get filtered when
extensions dropdown has selected values but extension is not selected in
component type dropdown

## 🔗 Related issue

Closes: #219
@Adam-it
Copy link
Contributor Author

Adam-it commented Aug 26, 2024

The related PR is closed and this is already part of a new pre-release.
Lets give it a bit of time and shortly after we will release a new minor with this included 👍.
Thank you for your contribution. You Rock 🤩👏

@Adam-it Adam-it closed this as completed Aug 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nicodecleyre nicodecleyre

Labels
⭐ enhancement New feature or request 👨‍💻work in progress I am working on it
Projects
None yet
Milestone
v3.X
Development

No branches or pull requests
2 participants
@nicodecleyre @Adam-it