Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

💡 [Feature]: Add more settings for the extension #200

Closed
2 tasks
Adam-it opened this issue Mar 23, 2024 · 2 comments
Closed
2 tasks

💡 [Feature]: Add more settings for the extension #200

Adam-it opened this issue Mar 23, 2024 · 2 comments
Assignees
@GuidoZam
Labels
⭐ enhancement New feature or request 💪 good first issue Good for newcomers 👨‍💻work in progress I am working on it
Milestone
v3.X

Comments

@Adam-it
Copy link
Contributor

Adam-it commented Mar 23, 2024 •
edited

🎯 Aim of the feature

We should extend the extension settings to allow to:

  • show hide service incident list
  • show hide tenant wide extensions

image

👣 How to start guide

extension settings are defined in the package.json. We should extend it with two new settings
image

we should move the getExtensionSettings to a separate util file and refactor the TerminalCommandExecuter to use this util
image

then in the CommandPanel we should modify the accountTreeView and appcatalogTreeView to execute the CliActions only if the setting is set to make those information visible
image
@Adam-it Adam-it added ⭐ enhancement New feature or request ✏️prototype labels Mar 23, 2024
@Adam-it Adam-it added this to the v3.1 milestone Mar 23, 2024
@Adam-it Adam-it added 🙏 help wanted Open for contributors and removed ✏️prototype labels Apr 17, 2024
@Adam-it Adam-it added the 💪 good first issue Good for newcomers label Jun 22, 2024
@Adam-it Adam-it self-assigned this Jul 14, 2024
@GuidoZam GuidoZam mentioned this issue Jul 28, 2024
Merged
1 task
@Adam-it Adam-it removed their assignment Jul 28, 2024
@Adam-it Adam-it added 👨‍💻work in progress I am working on it and removed 🙏 help wanted Open for contributors labels Jul 28, 2024
@GuidoZam
Copy link

Working on it! 😸

Adam-it added a commit that referenced this issue Aug 5, 2024
@GuidoZam @Saurabh7019
@Adam-it @DevPio
Adds settings to show and hide health incidents and tenant wide exten…
5e57f5d 
…sions. Closes: #200 (#281)

## 🎯 Aim

This PR implements the required settings of issue
[#200](#200).

## 📷 Result


![image](https://github.com/user-attachments/assets/ec83766a-d8c6-45f9-ad49-29fb53b82703)


## ✅ What was done

Added two settings for the extension:
- showServiceIncidentList
- showTenantWideExtensions

Updated the `TerminalCommandExecuter` extracting the
`getExtensionSettings` method and creating a dedicated util file.

Updated the `CommandPanel` to keep into account the new settings when
loading and showing data.

## 🔗 Related issue

Closes: #200

---------

Co-authored-by: Saurabh Tripathi <[email protected]>
Co-authored-by: Adam Wójcik <[email protected]>
Co-authored-by: Luccas Castro <[email protected]>
Co-authored-by: Adam Wójcik <[email protected]>
@Adam-it
Copy link
Contributor Author

Adam-it commented Aug 5, 2024

The related PR was merged 😍.
Soon we will release a new pre-release with this change.
After some time this will get merged to main branch and be part of a regular minor release.
After this will get merged to main branch you will also be mentioned in the repo contributors.
Thanks a ton 👏👏. You Rock 🤩

@Adam-it Adam-it closed this as completed Aug 5, 2024
Adam-it added a commit that referenced this issue Aug 6, 2024
@GuidoZam @Saurabh7019
@Adam-it @DevPio
Adds settings to show and hide health incidents and tenant wide exten…
b7e6d49 
…sions. Closes: #200 (#281)

## 🎯 Aim

This PR implements the required settings of issue
[#200](#200).

## 📷 Result


![image](https://github.com/user-attachments/assets/ec83766a-d8c6-45f9-ad49-29fb53b82703)


## ✅ What was done

Added two settings for the extension:
- showServiceIncidentList
- showTenantWideExtensions

Updated the `TerminalCommandExecuter` extracting the
`getExtensionSettings` method and creating a dedicated util file.

Updated the `CommandPanel` to keep into account the new settings when
loading and showing data.

## 🔗 Related issue

Closes: #200

---------

Co-authored-by: Saurabh Tripathi <[email protected]>
Co-authored-by: Adam Wójcik <[email protected]>
Co-authored-by: Luccas Castro <[email protected]>
Co-authored-by: Adam Wójcik <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@GuidoZam GuidoZam

Labels
⭐ enhancement New feature or request 💪 good first issue Good for newcomers 👨‍💻work in progress I am working on it
Projects
None yet
Milestone
v3.X
Development

No branches or pull requests
2 participants
@GuidoZam @Adam-it