Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

💡 [Feature]: The Upgrade and Validate actions could return also code tour response #188

Open
Adam-it opened this issue Mar 8, 2024 · 2 comments
Assignees
Labels
👨‍💻 CLI for Microsoft 365 Requires to first extend CLI for Microsoft 365 ⭐ enhancement New feature or request 💪 good first issue Good for newcomers
Milestone

Comments

@Adam-it
Copy link
Contributor

Adam-it commented Mar 8, 2024

🎯 Aim of the feature

As internally those actions use the project upgrade and project doctor CLI for M365 commands and those support also the tour output mode which create a code tour for the current project with the findings. We could extend those functionalities so that we return the markdown sum up report and the tour in one go.

Proposed implementation

In the CliActions service we the upgrade and validate methods. Each of those just run the CLI command under the hood with md output mode.
image

Depending on the what user have saved in the setting (see below) we should execute either the command with md or tour output or execute the commands twice with both output for both

Additional Proposal

Similar to node settings we could add additional setting for those features. For each of those features: upgrade and validate we could provide a dropdown with options that define what report type should be generated. Either: markdown (as we have now), code tour, both (which should be the default value)
image

@Adam-it Adam-it added ⭐ enhancement New feature or request ✏️prototype labels Mar 8, 2024
@Adam-it Adam-it added this to the v3.1 milestone Mar 8, 2024
@Adam-it Adam-it added 🙏 help wanted Open for contributors and removed ✏️prototype labels Apr 17, 2024
@Adam-it Adam-it added 💪 good first issue Good for newcomers 👨‍💻 CLI for Microsoft 365 Requires to first extend CLI for Microsoft 365 labels Jun 22, 2024
@nicodecleyre
Copy link
Contributor

Hi there 👋 , can i work on this one please?

@Adam-it Adam-it removed the 🙏 help wanted Open for contributors label Jun 25, 2024
@Adam-it
Copy link
Contributor Author

Adam-it commented Jun 25, 2024

Hi there 👋 , can i work on this one please?

Of course

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
👨‍💻 CLI for Microsoft 365 Requires to first extend CLI for Microsoft 365 ⭐ enhancement New feature or request 💪 good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants