Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing UserPicker control in the lib folder of the package #1925

Open
Adam-it opened this issue Dec 19, 2024 · 4 comments · Fixed by #1926
Open

Missing UserPicker control in the lib folder of the package #1925

Adam-it opened this issue Dec 19, 2024 · 4 comments · Fixed by #1926
Assignees
Labels
status:fixed-next-drop Issue will be fixed in upcoming release.
Milestone

Comments

@Adam-it
Copy link
Member

Adam-it commented Dec 19, 2024

Category

[x] Bug

Version

[3.20.0]

Expected / Desired Behavior / Question

I should be able to use the new UserPicker control importing it like import {} from "@pnp/spfx-controls-react/lib/UserPicker";

Observed Behavior

It does not work. Currently I need to specify the full path to the control like import {} from "@pnp/spfx-controls-react/lib/controls/userPicker/UserPicker";

I think in the src folder we are missing a UserPicker.ts file with the following content:

export * from './controls/userpicker/index';

We also don't see this control in docs
image

The page (url) works https://pnp.github.io/sp-dev-fx-controls-react/controls/UserPicker/
It is just not present in the left side menu

this is most probably due to the fact the mkdocs.yml was not extended in the nav -> Controls we should add something like

    - UserPicker: 'controls/UserPicker.md'

BTW the page has some strange glitch as well
image
BTW 2 the imagePicker docs added in the same build are missing as well, the same reason

Based on feed from PnP Discord server: https://discord.com/channels/1095788595010338956/1096363547505733632/1318921197765001248

Copy link

Thank you for submitting your first issue to this project.

@Adam-it
Copy link
Member Author

Adam-it commented Dec 19, 2024

@joelfmrodrigues, @AJIXuMuK
Did I miss anything in my research? If not may I kindly ask you to get assigned 🙏 so that I may fix it up ASAP.

@AJIXuMuK
Copy link
Collaborator

@Adam-it - the investigation is correct, thank you!
Please, feel free to create a PR and we'll review it!

@joelfmrodrigues
Copy link
Collaborator

PR merged :)

@joelfmrodrigues joelfmrodrigues added the status:fixed-next-drop Issue will be fixed in upcoming release. label Dec 20, 2024
@joelfmrodrigues joelfmrodrigues added this to the 3.21.0 milestone Dec 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status:fixed-next-drop Issue will be fixed in upcoming release.
Projects
None yet
3 participants