Build fails due to missing @iconify/react dependency after upgrade to 3.16.0

[ekdegerman]

Category

[ ] Enhancement

[x] Bug

[ ] Question

Version

3.16.0

Expected / Desired Behavior / Question

gulp bundle --ship completes with no issues, as it does on 3.15.0

Observed Behavior

There's a module not found error in webpack:

@iconify/react is listed under devDependencies rather than dependencies in package.json

Steps to Reproduce

1. Create a new spfx component for a web part using react as the framework
2. Install version 3.16.0 of the library
3. Add e.g. a ListItemAttachments component
4. run gulp bundle --ship

[ghost]

Thank you for reporting this issue. We will be triaging your incoming issue as soon as possible.

[github-actions]

Thank you for submitting your first issue to this project.

[wuxiaojun514]

I have the same issue when I upgraded to 3.16.

I installed "@iconify/react" as devDependencies, then it works.
You can try with
npm i -DE @iconify/react

[ekdegerman]

I have the same issue when I upgraded to 3.16.

I installed "@iconify/react" as devDependencies, then it works. You can try with npm i -DE @iconify/react

Yes, but if it is required for consumers I don't think it should be a devDependency in the first place... 🤔 The dependency and its version should be managed by the project that decides if it is needed rather than have all consumers having to keep track of that. Besides, it seems to be used as a regular dependency in the HoverReactionBarControl, which I guess could lead to issues in the finished build as well if that is used.

[joelfmrodrigues]

@ekdegerman thanks for reporting this. The PR from @GuidoZam to fix the issue has just been merged and a new beta release should be published in a few minutes.

[jeffseiffert]

I have the same issue when I upgraded to 3.16.

I installed "@iconify/react" as devDependencies, then it works. You can try with npm i -DE @iconify/react

I tried this then get the following error message.

[jtlivio]

Hello, i have the same issue with version 1.18.2, @joelfmrodrigues the PR was published? if yes problem remains in this version

Thanks

[joelfmrodrigues]

@jtlivio it's not published yet. There was a minor release to try to fix another issue, but didn't include this PR. I will start discussions for a major release to address this issue