-
Notifications
You must be signed in to change notification settings - Fork 388
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SPFx 1.18.x support #1705
Comments
Thank you for reporting this issue. We will be triaging your incoming issue as soon as possible. |
Thank you for submitting your first issue to this project. |
Update! A bit more digging, it seems to be depenant on the component, uncommenting this code snippet get's it to work <ListItemComments
webUrl={Statics.SiteUrls.ProjectSite}
listId={Statics.ListIds.Tasks}
itemId={Task.Id + ""}
serviceScope={SPFxContext.serviceScope as any}
/> |
Hi @Tanddant, I see a lot of errors regarding a bad engine, maybe the problem is that.
As you can see your current Node.js version is 18.17.1 but the required is >=16.13.0 <17.0.0 and this applied to most of the errors, maybe solving this will resolve all your problems 😉 |
Hi @GuidoZam I agree, but SPFx 1.18.x now uses node 18, so I'm guessing we would need to update the controls to support node 18 |
Sorry @Tanddant my bad, I misunderstood the issue. I saw that in the dev branch there is a recent merge supporting SPFx 1.18.1, maybe you should wait until it's merged on the master branch. |
No worries @GuidoZam, I should've been more clear in my post - or just checked the Dev branch 😂 Keeping my fingers crossed for a release soon 🤞 |
No problem 😆 finger crossed for you! |
@Tanddant hey, in the meantime, it would be great if you could test using the beta release to ensure that the issue was resolved |
@joelfmrodrigues Tried a
|
@Tanddant - please, remove spfx fast serve dependency from your solution. |
@AJIXuMuK - Nice spotted! - turns out the project had an older version of fast-serve installed, updating that solved the issue, and using the latest release of the controls, thanks a ton everyone! 🙌 |
Category
Version
Please specify what version of the library you are using: [3.15.0]
Expected / Desired Behavior / Question
Being able to install the package, and use i - I guess that's really all.
Observed Behavior
Since SPFx 1.18 changed the node version I'm having some issue, installing on a SPFx 1.18.1 solution gives me the following install log:
Running a
gulp serve
then gives me the following:And nothing will load, looking at the following two lines, but I have no clue where they're coming from
Steps to Reproduce
I get them just spinning up a SPFx 1.18.1 Project and running a
npm install @pnp/spfx-controls-react --save --save-exact
I'm down to try and help out, but I have no clue where to start 😅
The text was updated successfully, but these errors were encountered: