STYLE: Enforce ITK style defined by .clang-format

./Utilities/Maintenance/clang-format.bash \
  --clang-format ~/local/llvm/clang+llvm-8.0.0-x86_64-linux-gnu-ubuntu-18.04/bin/clang-format \
  --tracked

This patch updates the ITK preferred style to one that can be
automatically enforced, integrated with many IDE's, and based
on externally defined documentation and examples.

See: https://discourse.itk.org/t/update-coding-style-for-itk/2055

Most of the changes make inconsistent coding practices consistent
throughout the toolkit.  Community discussions regarding changes
to the current defined coding style are explicitly not included
in this request so that they can be independantly reviewed and
considered.

One large change is changing the {} indentation style from
`Whitesmiths` style https://en.wikipedia.org/wiki/Indentation_style#Whitesmiths_style
to an indentation style consistent with many of the other common
indentation styles.  The primary reason for this change is to
overcome the common deficiency of IDE's and formatters to support
this uncommon style choice.

Many ITK developers provided insightful comments and suggestions that
resulted in this set of style comprimises.

Author: hjmjohnson

.clang-format

@@ -1,11 +1,21 @@
 ## This config file is only relevant for clang-format version 8.0.0
+##
+## Examples of each format style can be found on the in the clang-format documentation
 ## See: https://clang.llvm.org/docs/ClangFormatStyleOptions.html for details of each option
 ##
-## The clang-foramt binaries can be downloaded as part of the clang binar distributions
+## The clang-format binaries can be downloaded as part of the clang binary distributions
 ## from http://releases.llvm.org/download.html
+##
+## Use the script Utilities/Maintenance/clang-format.bash to faciliate
+## maintaining a consistent code style.
+##
+## EXAMPLE apply code style enforcement before commit:
+#     Utilities/Maintenance/clang-format.bash --clang ${PATH_TO_CLANG_FORMAT_8.0.0} --modified
+## EXAMPLE apply code style enforcement after commit:
+#     Utilities/Maintenance/clang-format.bash --clang ${PATH_TO_CLANG_FORMAT_8.0.0} --last
 ---
 # This configuration requires clang-format version 8.0.0 exactly.
-#  BasedOnStyle: Mozilla
+BasedOnStyle: Mozilla
 Language:        Cpp
 AccessModifierOffset: -2
 AlignAfterOpenBracket: Align
@@ -29,7 +39,7 @@ AlwaysBreakAfterReturnType: All
 AlwaysBreakBeforeMultilineStrings: false
 AlwaysBreakTemplateDeclarations: Yes
 BinPackArguments: false
-BinPackParameters: true
+BinPackParameters: false
 BreakBeforeBraces: Custom
 BraceWrapping:
   # clang 9.0 feature AfterCaseLabel:  false
@@ -61,6 +71,7 @@ BreakBeforeTernaryOperators: true
 BreakConstructorInitializers: BeforeComma
 BreakAfterJavaFieldAnnotations: false
 BreakStringLiterals: true
+## The following line allows larger lines in non-documentation code
 ColumnLimit:     120
 CommentPragmas:  '^ IWYU pragma:'
 CompactNamespaces: false
@@ -103,6 +114,7 @@ ObjCSpaceBeforeProtocolList: false
 PenaltyBreakAssignment: 2
 PenaltyBreakBeforeFirstCallParameter: 19
 PenaltyBreakComment: 300
+## The following line allows larger lines in non-documentation code
 PenaltyBreakFirstLessLess: 120
 PenaltyBreakString: 1000
 PenaltyBreakTemplateDeclaration: 10
@@ -125,10 +137,10 @@ SpaceBeforeParens: ControlStatements
 SpaceBeforeRangeBasedForLoopColon: true
 SpaceInEmptyParentheses: false
 SpacesBeforeTrailingComments: 1
-SpacesInAngles:  true
-SpacesInContainerLiterals: true
+SpacesInAngles:  false
+SpacesInContainerLiterals: false
 SpacesInCStyleCastParentheses: false
-SpacesInParentheses: true
+SpacesInParentheses: false
 SpacesInSquareBrackets: false
 Standard:        Cpp11
 StatementMacros:

ARCHIVE/BRAINSContinuousClass/BRAINSContinuousClass.cxx

@@ -23,38 +23,38 @@
 #include <vector>
 #include <map>
 
-template < typename TSampleType >
+template <typename TSampleType>
 class LogisticRegressionSample
 {
 private:
-  std::vector< TSampleType > *     m_sample;
-  unsigned int                     m_label;
-  std::map< unsigned int, double > m_predictedProbability;
-  bool                             m_labelSet;
+  std::vector<TSampleType> *     m_sample;
+  unsigned int                   m_label;
+  std::map<unsigned int, double> m_predictedProbability;
+  bool                           m_labelSet;
 
 public:
-  LogisticRegressionSample( const unsigned int featureCount );
-  LogisticRegressionSample( const LogisticRegressionSample & LRS );
+  LogisticRegressionSample(const unsigned int featureCount);
+  LogisticRegressionSample(const LogisticRegressionSample & LRS);
   ~LogisticRegressionSample();
   double
-  GetLabelProbability( unsigned int const & );
+  GetLabelProbability(unsigned int const &);
 
   void
-  SetSample( std::vector< TSampleType > & );
+  SetSample(std::vector<TSampleType> &);
 
-  std::vector< TSampleType > const *
+  std::vector<TSampleType> const *
   GetSample() const;
 
   void
-  SetLabelProbability( unsigned int const &, double const & );
+  SetLabelProbability(unsigned int const &, double const &);
 
   unsigned int
   GetLabel() const
   {
     return this->m_label;
   };
   void
-  SetLabel( unsigned int const & );
+  SetLabel(unsigned int const &);
 
   bool
   LabelIsSet() const
@@ -63,7 +63,7 @@ class LogisticRegressionSample
   };
 };
 
-template < typename TSampleType >
+template <typename TSampleType>
 class LogisticRegression
 {
 private:
@@ -80,23 +80,23 @@ class LogisticRegression
   bool                  m_classTwoLabelSet;
 
 public:
-  LogisticRegression( const unsigned int featureCount, const unsigned int sampleCount );
-  LogisticRegression( const LogisticRegression & LR );
+  LogisticRegression(const unsigned int featureCount, const unsigned int sampleCount);
+  LogisticRegression(const LogisticRegression & LR);
   ~LogisticRegression();
   void
-  AddLabeledSample( LogisticRegressionSample< TSampleType > const & );
+  AddLabeledSample(LogisticRegressionSample<TSampleType> const &);
 
   void
   TrainModel();
 
   void
-  SetClassOneLabel( const unsigned int );
+  SetClassOneLabel(const unsigned int);
 
   void
-  SetClassTwoLabel( const unsigned int );
+  SetClassTwoLabel(const unsigned int);
 
   void
-  ClassifySample( LogisticRegressionSample< TSampleType > & );
+  ClassifySample(LogisticRegressionSample<TSampleType> &);
 };
 #include "LogisticRegression.hxx"
 #endif