Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Utilize the new pool interface #355

Open
shintaro-iwasaki opened this issue Jul 26, 2021 · 2 comments
Open

Utilize the new pool interface #355

shintaro-iwasaki opened this issue Jul 26, 2021 · 2 comments

Comments

@shintaro-iwasaki
Copy link
Collaborator

#354 introduced a new pool interface, which is more flexible and easy to implement. We should implement the following to fully utilize this new pool interface.

  • New user APIs (mainly pool routines) that accept ABT_pool_context
  • Clarification and revision of API descriptions
  • Predefined random work-stealing pool (ABT_POOL_RANDWS)
  • Predefined priority-aware pool ABT_POOL_PRIO_FIFO (or maybe ABT_POOL_PRIO_RANDWS ...?)
  • More examples (ring-buffer, LIFO, fine-grained priority control, ...)
@shintaro-iwasaki
Copy link
Collaborator Author

ABT_pool functions that accept ABT_pool_context were implemented by #357.
A predefined random work-stealing pool (ABT_POOL_RANDWS) was implemented by #359.

@shintaro-iwasaki
Copy link
Collaborator Author

Some users are still relying on the old customized pool API (see #366). We should create a unit test similar to https://github.com/pmodels/argobots/blob/main/test/basic/pool_user_def.c for the old custom pool API.

epmikida added a commit to Charmworks/argobots that referenced this issue Oct 15, 2021
This API is still used by some users according to issue pmodels#355 so we
want to make sure it is still tested.

Change-Id: I29b9c3726a738d78936028249f9c3f96e7216416
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant