Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

scene not rendered in latest react-three/fiber #19

Open
JosephClay opened this issue Jun 24, 2022 · 14 comments
Open

scene not rendered in latest react-three/fiber #19

JosephClay opened this issue Jun 24, 2022 · 14 comments

Comments

@JosephClay
Copy link

JosephClay commented Jun 24, 2022

The latest version of @react-three/fiber prevents rendering

Modified the example sandbox to demonstrate

Tried solving the issue locally. There seems to be 2 issues:

@unframework
Copy link
Collaborator

Hey, thanks a lot for looking into this and reporting the specific issues. I will try to fix this in the next few days.

@JosephClay
Copy link
Author

Let me know if I can help. I'm on the poimandres discord

@unframework
Copy link
Collaborator

I upgraded to latest React/r3f was able to repro the sceneRef.current issue, still figuring out a fix.

@vsabinin
Copy link

Hi guys,
I'm having the same issue.
Any idea how to fix it?

@unframework
Copy link
Collaborator

Hi Slava and others, I appreciate the long wait - a bit of a crunch at work but I should have some cycles this week to wrap this up.

@nikolai-sim
Copy link

Hey team any updates on this? Really keen to use this in a project. Thanks for the awesome work.

@unframework
Copy link
Collaborator

Thanks for checking in again! Yeah the last month has been really busy at work, I am hoping that time management improves in the coming week. Really appreciating the wait - suspense related issues are super finicky to try and figure out, hence why I need to dig in a bit deeper on this.

@03hgryan
Copy link

Hi, I am also very excited to use this in my project. Any updates? Thanks for amazing work!

@unframework
Copy link
Collaborator

unframework commented Aug 19, 2022

Ok, so I did some cleanup work and upgraded to React 18.

As is, the main branch now works with the latest React but I had to take out the fancy logic that triggered Suspense while baking was going on. So what you'll see currently is the intermediate lightmap texture flashing briefly on the models while baking is going on.

To help with that, I added an onComplete callback - so at least one can hide the scene initially until the baking is complete.

I will try to wrap up the new work on re-adding Suspense soon, and maybe treat that as a 0.1.0 release haha.

@03hgryan
Copy link

Thank you so much!!!

@03hgryan
Copy link

The update is not yet published to npm right?

@unframework
Copy link
Collaborator

The update is not yet published to npm right?

I did not push a new version to NPM yet, this is in a temporary state until I fix suspense 😅.

@03hgryan
Copy link

Oh okay okay, Thanks. I did not meant to rush you btw:)

@unframework
Copy link
Collaborator

Some more work in progress here: #23. I am moving the actual baking to work in a separate React root and WebGL context - this keeps logic a bit simpler (no need to clean up the temporary baker scene), and should plug into Suspense much better, because the process is completely independent of the suspended React tree.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants