Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

engine.io client requires ES6 to build #188

Open
milgner opened this issue Jan 7, 2020 · 3 comments
Open

engine.io client requires ES6 to build #188

milgner opened this issue Jan 7, 2020 · 3 comments

Comments

@milgner
Copy link

milgner commented Jan 7, 2020

It might be related to #183 but since the error message looks completely different and the setup is different, too, I'm putting this into a separate ticket.
First off: really nice project! The architecture is nicely thought through and very straightforward and the dashboard looks nice, too!

Trying to get it to run (Node 12.14.0, NPM 6.13.4 on Linux), the build script fails with:

static/js/main.821d85ae.js from UglifyJs
Unexpected token: name (index) [./~/engine.io-client/~/debug/src/browser.js:155,0][static/js/main.821d85ae.js:32369,5]

This seems to be because the engino.io-client package uses ES6 let syntax. The UglifyJS webpack plugin used by react-scripts however abandoned ES6 support and one is supposed to use terser instead 🤷‍♂️

Maybe the packages need to be locked at a specific (outdated?) version for things to work?

@snapfast
Copy link

I am experiencing the exact same issue. Any solutions to this?

@sela55
Copy link

sela55 commented Jun 1, 2020

Same problem here, is there any way to fix this?

@HelloJack0
Copy link

how to fix the error?
[3/5] Fetching packages...
info There appears to be trouble with your network connection. Retrying...
info [email protected]: The platform "win32" is incompatible with this module.
info "[email protected]" is an optional dependency and failed compatibility check. Excluding it from installation.
[4/5] Linking dependencies...
[5/5] Building fresh packages...
success Saved lockfile.
$ if $BUILD_ASSETS; then npm run build-assets; fi
此时不应有 then。
error Command failed with exit code 1.
info Visit https://yarnpkg.com/en/docs/cli/install for documentation about this command.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants