Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expected content of contributions for regional locales #7373

Open
ArgusMagnus opened this issue Feb 20, 2025 · 3 comments
Open

Expected content of contributions for regional locales #7373

ArgusMagnus opened this issue Feb 20, 2025 · 3 comments
Labels
community community contribution feature something new P3 backlog

Comments

@ArgusMagnus
Copy link

Follow-up on #2991

Was there ever a conclusion reached on this topic? If I were to make a PR for a regional locale, should I make it a full locale or should it only include the necessary differences from the parent?

@gvwilson
Copy link
Contributor

Hi @ArgusMagnus - if you look in the lib/locales directory in this repo you'll see (for example) fr.js and then fr-ch.js with differences, so I believe the answer is "necessary differences". Which language(s) are you thinking of localizing? thanks - @gvwilson

@gvwilson gvwilson added feature something new community community contribution P3 backlog labels Feb 20, 2025
@ArgusMagnus
Copy link
Author

Im thinking of "fixing" de-ch. Although looking at fr-ch Im unsure what the intent was with these. They both seem to have duplicated a few entries from their parents, but the "necessary differences" are actually missing. Do you know if that was an oversight or am I looking at this the wrong way?

@gvwilson
Copy link
Contributor

My guess is an oversight - a PR to correct it would be very welcome, and I can try to find native speakers of the related languages to review - thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community community contribution feature something new P3 backlog
Projects
None yet
Development

No branches or pull requests

2 participants