Skip to content

npm start Produces Error #7307

Open
Open
@samhinshaw

Description

@samhinshaw

Running npm start on master produces an error: "module is not defined".

Steps to Reproduce

  1. Run npm start

Expected Behavior

I started writing up this ticket because I thought this broke the test dashboard. However, it appears this console error is simply erroneous.

Actual Behavior

The test dashboard actually does not appear to break, despite the console error.

Additional Details

The CommonJS export syntax in //devtools/test_dashboard/devtools.js is at fault. It appears that ESBuild does not strip this out on build. To fix this, we could:

  1. Remove the module.exports = Tabs line if this export is not needed elsewhere.
  2. Create another file (e.g. index.js), import the devtools from there const Tabs = require('./tabs');, and point ESBuild at that.
Image

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugsomething broken

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions