Loaded plopfiles do not respect the --force flag

[moltar]

I know it worked on previous versions, and I suspect it might be my local setup, but want to raise an issue to see if there are any other leads, as I've spent over an hour trying to debug this, and so far no leads.

Running

## for TS support
export NODE_OPTIONS="--loader ts-node/esm --no-warnings"

plop --force --plopfile=.plop/plopfile.ts        

Output:

? What is your name? asd
✖  ++ File already exists
 -> /../project/.plop/foo-bar

.plop/plopfile.ts contents:

import type { NodePlopAPI } from 'plop';

module.exports = function (plop: NodePlopAPI) {
  plop.setGenerator('test', {
      description: 'This is loaded.',
      prompts: [{
        name: 'name',
        message: 'What is your name?',
        type: 'input',
      }],
      actions: [
        {
          type: 'add',
          template: 'foo {{name}}',
          path: 'foo-bar',
        }
      ]
  });
};

Version

❯ pnpm ls plop

devDependencies:
plop 3.1.2

---

Btw, if I use force: true on the action, then it works fine.

[moltar]

Alright, as soon as I opened an issue, had an idea... (of course!) 💡 😁

---

I was actually using a loaded plop file from the main file, and that is what triggered this bug!

So it looks like force is not being applied to loaded plopfiles.

plopfile.ts

import type { NodePlopAPI } from 'plop';

module.exports = async function (plop: NodePlopAPI) {
  await plop.load('./name.ts')
};

name.ts

import type { NodePlopAPI } from 'plop';

module.exports = function (plop: NodePlopAPI) {
  plop.setGenerator('test', {
      description: 'This is loaded.',
      prompts: [{
        name: 'name',
        message: 'What is your name?',
        type: 'input',
      }],
      actions: [
        {
          type: 'add',
          template: 'foo {{name}}',
          path: 'foo-bar',
        }
      ]
  });
};

[crutchcorn]

That clarification is extremely helpful. Lemme see if I can take a stab at finding the root cause

[crutchcorn]

I think this is because we don't inherit any of the parent config props from our load method:

https://github.com/plopjs/plop/blob/main/packages/node-plop/src/node-plop.js#L102-L107

I could be wrong, but I think if we simply changed the const config lines to:

    const config = Object.assign(
      plopCfg,
      {
        destBasePath: getDestBasePath(),
      },
      loadCfg
    );

It would fix this bug.

Any chance you wanna pull it down, test my theory, maybe write a test to validate this fix, and make a PR? 😊

[moltar]

Your fix does indeed work! :)

[moltar]

FYI I am working on a PR.

[crutchcorn]

BTW @moltar I deeply appreciate you having opened a PR. I'm working on TS support given our botched 4.0 release right now, but I will address your fix soon there after :)