Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Links broken in auto-generated PR text #1003

Closed
laowantong opened this issue Mar 27, 2024 · 3 comments
Closed

Links broken in auto-generated PR text #1003

laowantong opened this issue Mar 27, 2024 · 3 comments

Comments

@laowantong
Copy link

What happens?

When I open a PR a boilerplate is generated. The generated links seem to be broken, e.g.:

📚 Documentation preview 📚: https://jupysql--1002.org.readthedocs.build/en/1002/

To Reproduce

Just open a PR.

OS:

MacOS

JupySQL Version:

0.10.0

Full Name:

Aristide Grange

Affiliation:

Université de Lorraine

@edublancas
Copy link

it's not broken, that's the documentation preview. building the docs takes a few mins so the URL will work until the build is done

@edublancas edublancas closed this as not planned Won't fix, can't repro, duplicate, stale Mar 27, 2024
@edublancas
Copy link

those were indeed broken, fixed them, thanks

https://github.com/ploomber/jupysql/blob/master/.github/pull_request_template.md

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants