Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Local test runs generate telemetry data by default #26

Open
yafimvo opened this issue Jan 5, 2023 · 5 comments
Open

Local test runs generate telemetry data by default #26

yafimvo opened this issue Jan 5, 2023 · 5 comments

Comments

@yafimvo
Copy link
Collaborator

yafimvo commented Jan 5, 2023

We should consider disabling the telemetry by default when running tests locally.

@idomic @edublancas

@idomic
Copy link
Contributor

idomic commented Jan 5, 2023

We need to add a fixture to each of the repos conftest

@edublancas
Copy link
Contributor

We have it here . We can make it part of this package so only import it in other places.

e.g., importing this into any other package conftest.py:

from ploomber_core._testing import block_posthog

Should define the fixture and block posthog

@edublancas
Copy link
Contributor

I think it's now a good time to revisit the logic. seems like this feature depends on two fixture definitions monkeypatch_session, and external_access. Insure if we need both and also unsure about the scope='class' argument since we're not using class-based test suites.

@idomic
Copy link
Contributor

idomic commented Jan 5, 2023

I think what probably is missing is the import piece, we've been seeing test events into posthog

@edublancas
Copy link
Contributor

this has not been implemented: from ploomber_core._testing import block_posthog

I'm suggesting we implement it so we can import it in this repo's contest and all others.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants