Using ${navigation_root_url} or ${portal_url} in Link type does not work

[yurj]

How to reproduce:

• go to demo.plone.org
• login as admin
• add a Link
• insert ${navigation_root_url} as the help suggests
• the link is rendered as http://${navigation_root_url} and not as https://demo.plone.org/

[boring-cyborg]

Thanks for opening your first issue here! Your engagement is essential for open source projects, including Plone. 🤗

If you haven't done so already, read Plone's Code of Conduct. Also please follow the issue template, as it helps both you and other community members contribute more effectively.

If your issue is a feature request, others may raise its prominence through feature voting.

Welcome to the Plone community! 🎉

[yurj]

Consider also this issue: plone/plone.app.contenttypes#712. z3c.form is not used by Volto so not an issue here but the serialization should be ok (the Link containing ${navigation_root_url} or ${portal_url} is converted in REST API: plone/plone.app.contenttypes#711).

[stevepiercy]

@yurj, after you closed that other issue plone/plone.volto#176, I looked again and realized that this might be also a UX issue. I made the same mistake, reading the help text instead of looking at the icon that looks like an electrical diagram for internal links.

It has aria-label="openUrlBrowser" on the button, but there's no tooltip. It should have one.

I'd also suggest improving the help text, as this feature does not seem to support templating.

If you agree, then we can add sub-issues to this issue.

[yurj]

As you prefer, but overdocumenting issues can scare people. I mean, a problem is fixed when someone needs it to be fixed. I think the icon is OK because it is the one Volto uses to pick up items in Slate. I just was not used to it.

I would change the help text and remove any reference to the template feature. IMHO, in the future, when someone will need it to work because of some project special needs, it will be implemented in the UI.

[davisagli]

I would change the help text and remove any reference to the template feature. IMHO, in the future, when someone will need it to work because of some project special needs, it will be implemented in the UI.

It's a bit complicated because the help text comes from the schema from the backend, and the templating feature does work in Classic UI afaik.

We can't simply replace the variables in the REST API, because then the replacements will also be seen when editing the link. So I think this probably needs to be handled in Volto in the LinkView (which is why I moved the issue here).