Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing CSS Rule in grid.plone.less - Grid is broken by custom Build #112

Open
1letter opened this issue Sep 7, 2016 · 0 comments
Open

Comments

@1letter
Copy link
Contributor

1letter commented Sep 7, 2016

The following Situation:
I build my custom CSS and use some barceloneta less files, especially the Grid Definitions.

My CSS Less File:

// Core variables and mixins
@import "++theme++barceloneta/less/variables.plone.less";
@import "++theme++barceloneta/less/mixin.clearfix.plone.less";
@import "++theme++barceloneta/less/mixin.gridframework.plone.less"; //grid Bootstrap
@import "++theme++barceloneta/less/mixin.grid.plone.less"; //grid Bootstrap
@import "++theme++barceloneta/less/normalize.plone.less"; // Reset and dependencies
@import "++theme++barceloneta/less/grid.plone.less"; //grid Bootstrap

... here my own defs
h1{color:red;}

The normal Bootstrap Grid, for Example this:

<div class="row">
  <div class="col-md-1">.col-md-1</div>
  <div class="col-md-1">.col-md-1</div>
  <div class="col-md-1">.col-md-1</div>
  <div class="col-md-1">.col-md-1</div>
  <div class="col-md-1">.col-md-1</div>
  <div class="col-md-1">.col-md-1</div>
  <div class="col-md-1">.col-md-1</div>
  <div class="col-md-1">.col-md-1</div>
  <div class="col-md-1">.col-md-1</div>
  <div class="col-md-1">.col-md-1</div>
  <div class="col-md-1">.col-md-1</div>
  <div class="col-md-1">.col-md-1</div>
</div>
<div class="row">
  <div class="col-md-8">.col-md-8</div>
  <div class="col-md-4">.col-md-4</div>
</div>
<div class="row">
  <div class="col-md-4">.col-md-4</div>
  <div class="col-md-4">.col-md-4</div>
  <div class="col-md-4">.col-md-4</div>
</div>
<div class="row">
  <div class="col-md-6">.col-md-6</div>
  <div class="col-md-6">.col-md-6</div>
</div>

is broken, because the Definition:

* {
  -webkit-box-sizing: border-box;
  -moz-box-sizing: border-box;
  box-sizing: border-box;
}
*:before,
*:after {
  -webkit-box-sizing: border-box;
  -moz-box-sizing: border-box;
  box-sizing: border-box;
}

is missing.
Please add this to grid.plone.less or normalize.plone.less

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant