Skip to content

Commit 8c6ab20

Browse files
committed
improve bad int message
1 parent d33092b commit 8c6ab20

File tree

3 files changed

+7
-3
lines changed

3 files changed

+7
-3
lines changed

src/plone/restapi/deserializer/__init__.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -44,4 +44,4 @@ def parse_int(data, prop, default):
4444
try:
4545
return int(data.get(prop, default))
4646
except (ValueError, TypeError):
47-
raise BadRequest("Invalid %s" % prop)
47+
raise BadRequest(f"Invalid {prop}: Not an integer")

src/plone/restapi/tests/test_batching.py

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -188,7 +188,11 @@ def test_batching_links_omitted_if_resulset_fits_in_single_batch(self):
188188
def test_batching_badrequests(self):
189189
response = self.api_session.get("/collection?b_size=php")
190190
self.assertEqual(response.status_code, 400)
191-
self.assertIn("invalid literal for int()", response.json()["message"])
191+
self.assertIn("Invalid b_size", response.json()["message"])
192+
193+
response = self.api_session.get("/collection?b_size:list=1")
194+
self.assertEqual(response.status_code, 400)
195+
self.assertIn("Invalid b_size", response.json()["message"])
192196

193197

194198
class TestBatchingDXFolders(TestBatchingDXBase):

src/plone/restapi/tests/test_services_navigation.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -246,4 +246,4 @@ def test_navigation_badrequests(self):
246246
)
247247

248248
self.assertEqual(response.status_code, 400)
249-
self.assertIn("invalid literal for int()", response.json()["message"])
249+
self.assertIn("Invalid expand.navigation.depth", response.json()["message"])

0 commit comments

Comments
 (0)