Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend substrate pallets for parachain runtimes #167

Merged
merged 3 commits into from
Nov 1, 2022

Conversation

vayesy
Copy link
Member

@vayesy vayesy commented Oct 19, 2022

Added next pallets to both zero and subzero chains:

  • democracy
  • multisig
  • proxy
  • membership
  • tips
  • elections phragmen
  • additional pallet dependencies for above.

@vayesy vayesy requested review from FiberMan and vovacha October 19, 2022 13:37
@vayesy vayesy self-assigned this Oct 19, 2022
@vayesy vayesy force-pushed the feature/add-democracy-pallets branch 2 times, most recently from 9d2c90e to 8b57623 Compare October 19, 2022 15:20
@vayesy vayesy requested a review from 2075 October 19, 2022 15:21
@vayesy vayesy marked this pull request as ready for review October 19, 2022 15:21
@vayesy vayesy linked an issue Oct 20, 2022 that may be closed by this pull request
4 tasks
Copy link
Member

@2075 2075 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems like it is still incomplete / dysfunctional.
also collator nomination seems to be missing.

@2075
Copy link
Member

2075 commented Oct 20, 2022

@vayesy
Copy link
Member Author

vayesy commented Oct 21, 2022

@2075 could you extend your answer why do you think it's incomplete / dysfunctional?

As for collator nomination - this wasn't mentioned in the scope of current task. But here are my thoughts on this: at the moment our chain has no collator rewards for proposed blocks. Taking this into account, there are no incentives for other members to participate in collation process. We might think of ways to implement it, but there is no general way to go at the moment. Default rewards implementation (minting reward tokens and distributing them to collators) would introduce inflation for our network, meaning amount of existing tokens increase over time and cost for a single token decreases over time. So this is separate task and discussion, which shouldn't take place here.

@2075
Copy link
Member

2075 commented Oct 21, 2022

@2075 could you extend your answer why do you think it's incomplete / dysfunctional?

As for collator nomination - this wasn't mentioned in the scope of current task. But here are my thoughts on this: at the moment our chain has no collator rewards for proposed blocks. Taking this into account, there are no incentives for other members to participate in collation process. We might think of ways to implement it, but there is no general way to go at the moment. Default rewards implementation (minting reward tokens and distributing them to collators) would introduce inflation for our network, meaning amount of existing tokens increase over time and cost for a single token decreases over time. So this is separate task and discussion, which shouldn't take place here.

regarding incomplete: see first screenshot

yes, this is not part of a ticket, coming from the initial thesis:

  • alphaville was a npos prototype incentivising validator operators to contribute to building a decentralised network. for me the way to go, also according to our product thesis.
  • subzero as a parachain lacks incentive for people to operate at the moment.
  • the way it is built now assumes a permissioned consortium style network, which is not where we are heading at or from my point of view could but should not head to.
  • as a result we should incentivise people to
    • operate collators
    • get rewards for that
    • have a determined amount of collators which can be nominated / delegated
    • from all collators a subset are selected e.g. random to be in the collator set
    • therefore incentive is there to run a collator and through nomination/delegation/selection enough incentive is there to support as a community and get commercial rewards

what alternatives do you have in mind?

@vovacha
Copy link
Contributor

vovacha commented Oct 21, 2022

seems like it is still incomplete / dysfunctional.
regarding incomplete: see first screenshot

@2075
The idea of this PR is to add three pallets: democracy, multisig, and proxy.
In the first screenshot, there is a council and nothing about mentioned pallets. What did you mean?

@2075
Copy link
Member

2075 commented Oct 21, 2022

the first screenshot shows the existence of the council pallet but no option to join

@vayesy
Copy link
Member Author

vayesy commented Oct 21, 2022

Users shouldn't have direct access to join councils on their behalf.
They can introduce their candidacy and result will be decided by voting outcome.

@2075
Copy link
Member

2075 commented Oct 21, 2022

yes, can you show an example to achieve this on the current parachain?

@vayesy
Copy link
Member Author

vayesy commented Oct 21, 2022

Thanks, I'll check it out.

@vayesy
Copy link
Member Author

vayesy commented Oct 24, 2022

Additionally extended pallets with membership, tips, elections.

Copy link
Contributor

@vovacha vovacha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Let's add testing scenario for each PR since we have no CI/CD yet. Something like: build --release ok, build --benchmarks ok, make test ok.

@5-mark
Copy link
Collaborator

5-mark commented Oct 27, 2022

@vayesy seems like this PR doesnt run through (failing after 16s).
Can you fix it?

@vayesy
Copy link
Member Author

vayesy commented Oct 27, 2022

@5-mark this is part of old CI/CD logic (I believe it is cloned with all the source code from other repository). It's not relevant and actually should be removed, so this shouldn't be taken into account at the moment.

@2075
Copy link
Member

2075 commented Oct 31, 2022

@vayesy pls look into the conflicts

Copy link
Member

@2075 2075 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@vayesy vayesy force-pushed the feature/add-democracy-pallets branch from 8b34ec7 to 519b85b Compare November 1, 2022 12:52
@vayesy vayesy merged commit 5e49a32 into dev Nov 1, 2022
@vayesy vayesy deleted the feature/add-democracy-pallets branch November 3, 2022 20:11
@vayesy vayesy mentioned this pull request Feb 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Democracy Link disappeared
5 participants