-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extend substrate pallets for parachain runtimes #167
Conversation
9d2c90e
to
8b57623
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
seems like it is still incomplete / dysfunctional.
also collator nomination seems to be missing.
nominate or delegate? articles |
@2075 could you extend your answer why do you think it's incomplete / dysfunctional? As for collator nomination - this wasn't mentioned in the scope of current task. But here are my thoughts on this: at the moment our chain has no collator rewards for proposed blocks. Taking this into account, there are no incentives for other members to participate in collation process. We might think of ways to implement it, but there is no general way to go at the moment. Default rewards implementation (minting reward tokens and distributing them to collators) would introduce inflation for our network, meaning amount of existing tokens increase over time and cost for a single token decreases over time. So this is separate task and discussion, which shouldn't take place here. |
regarding incomplete: see first screenshot yes, this is not part of a ticket, coming from the initial thesis:
what alternatives do you have in mind? |
@2075 |
the first screenshot shows the existence of the council pallet but no option to join |
Users shouldn't have direct access to join councils on their behalf. |
yes, can you show an example to achieve this on the current parachain? |
Thanks, I'll check it out. |
Additionally extended pallets with |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Let's add testing scenario for each PR since we have no CI/CD yet. Something like: build --release ok, build --benchmarks ok, make test ok
.
@vayesy seems like this PR doesnt run through (failing after 16s). |
@5-mark this is part of old CI/CD logic (I believe it is cloned with all the source code from other repository). It's not relevant and actually should be removed, so this shouldn't be taken into account at the moment. |
@vayesy pls look into the conflicts |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
8b34ec7
to
519b85b
Compare
Added next pallets to both
zero
andsubzero
chains: