-
-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Design - theme widget #24
Comments
tasks -
|
feedback -
|
tasks -
|
tasks -
|
feedback I am okay with the Otherwise it looks great. I do think once we have all remaining features figured out, we need to create a very detailed and accurate interactive clickable prototype, so ali can see and make our real graph explorer work the same. I would recommend to use the exact dataset we have in the playproject website for that interactive prototype :-) |
tasks -
|
tasks -
|
tasks -
|
feedback see discord |
tasks -
|
tasks -
|
tasks -
|
tasks -
|
tasks -
|
tasks -
|
tasks -
|
tasks -
|
feedback worklog-47 #24 (comment)remaining feedback worklog 47In worklog 47 you share there is a problem with the command list In worklog 47 you talk about he command history and compare it to devtools and how there is a button to select icons. This is all a perfect idea and it should exactly work like this, but i dont think we need that special "select icon", because if the command history is expanded and you click a different bread crumb or entry in the graph explorer, the command history will automatically adapt its view to it. create theme suggestion feedback
So in the case above, you need multiple form inputs to really specify what will happen
So as a "steps wizard" in the datdot sense, this action wiard should have 2 steps before completing/submitting the form and trigger the action execution. Lastly, the "PREVIEW" should be seperate from the wizard and should get updated with each completed wizard step. Maybe the first step should be to select theme content and the second one to select a name. One thing to notice: But yes - if an action or command requires to get files, then that is something that should happen in In the context shown above, you would probably have a step to first select the "mode"
There should be a fine scroll bar (just like vscode editor tabs bar does it) to indicate that worklog-48 #24 (comment)
The icon not, but at least the text is shown correctly in a later version in the worklog: It was good, that in the bread crumbs, the 1.css had a slightly different focus highlight color.
Let me know, but i thought no matter which Especially later in the worklog you show both at once: What i can imagine or see is yet another icon next to e.g.
Now what this also suggest is, that when the editor is collapsed, we might still want to be able to see and switch or re-open any "open file", such as any of the tabs below the tabbed editor, thus, while an editor should be collapsible, maybe the tabs bar should still be visible. In fact, each tab, when you click it (lets assume they are different and not all just editor tabs for
AGAIN - here you mention a problem with the
And what if we toggle ...overall, questions over questions. Whats you take on this? Given that, i kind spontaneously feel like maybe the special extra "doc box" on top of the entire app was better? ...hmm - just brainstorming still. Also - a bit "meta", but i just had another thought about this:
Also navigation wise thats true:
|
feedback worklog-49 #24 (comment)
But beyond that, i think we have to take a moment to think about all the things we need to do.
|
feedback worklog-50 #24 (comment)It looks okay. I do think what matters for the terminal version is to actually draw the UI Another important aspect of the terminal UI is to define one that works by entering commands. To explain what i mean:
Regardless, you can type git commands in a terminal to update a git repository. So if all you had were command line commands, how would you "see" or "change" the things I think that should be the task for maybe ali and/or ahmed. Once we have the "web version", we will then try to translate it into a terminal UI as well. So please continue with this style, but now lets do it for the web again :-)
We should work on a general "wizard steps" component, where each action or command, such as "new theme" can define its own set of data requirements, which will then show one or more steps in a step wizard to prompt the user to use the different input widgets to provide the requested data :-) Next to datdot steps wizard, we can also additionaly take inspiration from discord Basically, just think that this kind of "new theme" feature example would work for ANY action and the input prompts can be customized based on actions, but they all have in common, that they will prompt the user to collect data needed to execute the action. Users need to be able to cancel, confirm, got back and forth, see a preview, etc... when filling out the form step by step before finally submitting to execute or abort the command. Basically: The input field in the command bar is probably not the right place for the various possible input widgets, because not all of them would fit in there. Finally, building up a preview before submitting the action would be good as well, to show somehow what kind of new data entry ot action and effect we are creating by filling out the form. Technically, if there are different alternative options in a step wizard, then "next steps" could depend on filling out a "previous step". Thats entirely possible :-)
As you say in the end - a "change theme" command is yet another possible command we can then design :-) ...not just that, there can be many more commands to help do stuff. Maybe at some point people can install/uninstall those kind of commands with their corresponding steps wizards or even program commands themselves and publish them for others to install those... we'll see. For now we just create the basics to later allow such things. command history
command list
high contrast themeAt last you quickly show the alternative theme with the orange. |
feedback worklog-51 #24 (comment)The hackmd slides look great.
Kinda like this...
You also had already versions with that desinged, like here: Anyway, generally, the good part here is, that because options are so limited, it helps us to keep things basic, but as mentioned in the last feedback.
So no need to type in /history or whatever.
The problem here is that it is hard to show boxes side by side, so instead, it is better Basically what can be seen here:
Again, repeating feedback from worklog 47 or 48.
It also makes me think, that we might NOT create a full blown terminal UI with tiling boxes and all the stuff we designed for the web UI.
Thats it. various other things
Or maybe we only have the 🪄 in front and then all other icons in the end like we had it here: Maybe this has to be considerd in combination with the "tabs bar" and my feedback regarding that and also the difference between a long bottom bar like on desktop and a short one, like on mobile.
Once we have everything finalized, we can also make a "pretty" theme or multiple :-) |
feedback I checked your explanation videos you made for ahmed. I guess we will just need to wait for a new figma iteration that includes all the feedback from worklogs 47-51 :-) |
tasks -
|
feedback Perfect. Shared all feedback on discord. You can then at some point also review ahmeds worklog to give him feedback :-) |
@todo
@input
📦 theme_widget UX Improvement_discord messages@input
📦 play project@output
📦theme_widget-v0.0.0
from comment@input
📦 theme_widget UX Improvement_discord messages@input
📦 play project@output
📦theme_widget_tree-v0.0.0
from comment@input
📦 graph_explorer_component_discord messages@input
📦 graph_explorer_widget_discussion_discord messages@output
📦theme_widget_tree-v0.0.1
from comment@input
📦 graph_explorer_component_discord messages@input
📦 graph_explorer_widget_discussion_discord messages@output
📦theme_widget_tree-v0.0.2
from comment@input
📦 43-feedback & discussion_discord messages@input
📦 worklog-Cypher_discord messages@input
📦 graph explorer_discord messages@input
📦 github_feedback@output
📦breadcrumb_v0.0.0
from comment@input
📦 44-feedback & discussion_discord messages@output
📦theme_widget_step by step_v0.0.0
from comment@input
📦 45-feedback & discussion_discord messages@output
📦theme_widget_step by step_v0.0.1
from comment@input
📦 46-feedback & discussion_discord messages@input
📦 githubfeedback-worklog-46@output
📦theme_widget_step by step_v0.0.2
from comment@input
📦 47-feedback & discussion_discord messages@input
📦 githubfeedback-worklog-47@output
📦theme_widget_step by step_v0.0.3
from comment@input
📦 47-feedback & discussion_discord messages@input
📦 githubfeedback-worklog-47@output
📦theme_widget_step by step_v0.0.4
comment@input
📦 graph-explorer-feedback & discussion_discord messages@output
📦theme_widget - Terminal UI-v0.0.1
comment@input
📦 graph-explorer-feedback & discussion_discord messages@output
📦Theme_widget
comment@input
📦 theme_widget step by step v0.0.4@input
📦 theme_widget step by step hackmd@output
📦theme_widget explantion video pt 1
@output
📦theme_widget explantion video pt 2
comment@input
📦 Github Worklog 49 feedback@input
📦 Steps wizard & commands action bar- discord@output
📦theme_widget step by step v0.0.5
commentThe text was updated successfully, but these errors were encountered: