Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Perf by using bytes #7

Open
pyrossh opened this issue Jun 14, 2016 · 0 comments
Open

Improve Perf by using bytes #7

pyrossh opened this issue Jun 14, 2016 · 0 comments

Comments

@pyrossh
Copy link
Contributor

pyrossh commented Jun 14, 2016

Its seems the graphql-go guys tested their library for performance and improved it by a factor of 30 by using bytes instead of string. So I checked the source and even we are using string which causes a lot of garbage collection it seems so I guess we also need to make the change later to seem how much perf we gain.

References:
graphql-go/graphql@065ab6b
graphql-go/graphql#119

We should take a look at this lib for improving the lexer,
https://github.com/tdewolff/buffer

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant