Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Undo/Redo causes unwanted rotation #232

Closed
simonbethke opened this issue Oct 23, 2024 · 2 comments · Fixed by #361
Closed

Undo/Redo causes unwanted rotation #232

simonbethke opened this issue Oct 23, 2024 · 2 comments · Fixed by #361
Assignees
Labels
bug Something isn't working

Comments

@simonbethke
Copy link
Contributor

Steps to reproduce:

  1. Open a scene
  2. Rotated it by typing a number in the rotation
  3. Make a rectangular selection
  4. Delete it using the del-key
  5. Undo that using CTRL-Z
  6. Press CTRL-Z again (no effect)
  7. Now click the Undo-Button (the selection will rotate shortly and then rotated back)
  8. Click the Redo-Button (you have a rotated selection)
@willeastcott willeastcott added the bug Something isn't working label Oct 23, 2024
@willeastcott willeastcott changed the title Undo Hickup Undo/Redo causes unwanted rotation Oct 23, 2024
@slimbuck
Copy link
Member

I suspect this has to do with the keyboard focus.

If the number entry has focus then undo is handled by the edit box itself, not the undo system.

@simonbethke
Copy link
Contributor Author

If that is the case, you need to remove the focus when adding operations to the history stack. Also you need to ensure, that the default text-undo is prevented

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants