Improve top bar design #5858
Improve top bar design #5858
Conversation
- Improve button styles and consistency in top bar - Update filter pill style - Update filter menu style - Change realtime view to show current visitors and last updated in top bar rather than in the graph tabs - Update tooltip style and add delay to show tooltip - Update main graph tabs style
|
| : null, | ||
| seeMoreWidth: | ||
| SEE_MORE_LEFT_MARGIN_PX + | ||
| SEE_MORE_WIDTH_PX + |
There was a problem hiding this comment.
I know this is a draft, so feel free to ignore, but for the math to work out, this value needed to be known and used in the calculations.
If you open https://pr-5858.review.plausible.io/plausible.io?f=is,country,US&f=is,page,/open-source-website-analytics&f=is,region,US-TX&l=US,United%20States&l=US-TX,Texas at 550px width (just random example), we expect the query period menu not to overflow the bar, but it does, even though it would be possible to avoid overflow if the Country is United States filter wrapped into the vertical menu.
Left: PR, right: staging
I know it's weird to hard code the width of the button in PX: I used to dynamically measure it, but it created a loop where it first needed to be drawn (let's say with size-5), then measured, then maybe thrown away.
Changes
Tests
Dark mode