I've done a first-cut implementation of the icon update here - https://github.com/phatcher/Azure-PlantUML/tree/feature/iconupdate

I've changed the processing to use the latest icon set and rename the files as per the existing convention, trying to incorporate the new stuff without too many breaking changes.

Have a look and let me know what you think

@Potherca I've pushed a later change which avoids renaming the source files and includes 200+ new icons

Couple of issues...

1. Some of the icons are malformed e.g. AzureCORS, even though the original svg looks ok - attempted to fix this with conditional FitToCanvas but it's still not working.
2. I seem to have broken the PPTX generation, but can't figure out why.
3. Should we remove obsolete services/icons or leave them in the distribution?

Hi! I've had a first look, nothing obviously wrong stands out.

I hope to have more time after the weekend to look into things in more detail and properly address your question.

@Potherca Can you free up sometime to progress this

I got roped into a government project related to COVID, so I've been running low on spare time. Starting this weekend, I should be able to allocate more time to FOSS projects. This project (and the rest of PlantUML StdLib) is high on my list.

I'll keep you posted!

@phatcher I've had some time to look through your feature/iconupdate branch. Could you open an merge-request? That would make it easier to talk about (and resolve) the specific issues you mentioned.

@Potherca Done

I've been incrementally reviewing the MR.

Thing that stands out thus far:

• I think we'd want to replaced space characters in file names with a dash -
• The .vscode/.aunch.json contains hard-coded C:/Users/paulh/.dotnet/ ... it should be possible to replace that with a variable, but I'd have to look up what/how
• Same for paths in scripts/main.csx, should be variables if at all possible...

I need to take another final look at scripts/main.csx, but thus far everything is okay.

I'm thinking of splitting the MR into code changes and SVG/PNG/UML files. My browser doesn't like me looking at the MR much right now...

• I'll update the file paths with -
• I'll do some research on the hard coding
• Not sure if it's possible to split the MR easily since the code + images are tightly coupled due to the change in structure in the official image zip

Not sure if it's possible to split the MR easily since the code + images are tightly coupled due to the change in structure in the official image zip

Fair point. A similar result might also be achieved by splitting the commits between code and non-code changes. Anything splits the binaries and code would help.

@Potherca I've pushed some more changes to the branch

• Replaced the with a -
• Replaced the hardcoded path in .vscode\launch.json with ${env:USERPROFILE}
• Found a few more official icons, so added them in.

One idea would be that I take a branch from master and just apply the code changes to it, it won't run since all the images will be wrong etc but might simplify your review?

@Potherca I've pushed some more branches, let me know if you want a different pull request...

• feature/iconupdate-code : Has all of the code changes
• feature/iconupdate-img: Has the new manual images, plus the code
• feature/iconupdate: Has everything including the changed dist folder

I've just reviewed the code. The separate branch helped a lot, thank your for that!

It all looks good to me. I'm currently not on a system that run .NET so I can't run the code right now. Once I've run the code to be 100% sure, this can be merged.

I would like to thank you again for your awesome work on this!