feat(Rails7): Update for Rails 7 and MySQL 8 (#2)

* Override raw_execute to be compatible with Rails 7+

* Add a changelog and bump version for release

* Update Appraisals to run on modern Rails

* Depend on ActiveRecord 7 and up

* Fix docker-compose config format

* Add GitHub workflow for specs

* Mark unsafe sql as safe for this spec

* Also handle ActiveRecord::DatabaseConnectionError

* Fix typos

* Test with MySQL 8

* Fix spec for MySQL 8, where auto_increment still goes up

* Update badge and words in readme

* Combine old and new changelog, update with undocumented versions

* Do not retry on ActiveRecord::StatementTimeout errors

* lock to ~> 7.0.0 and add a note for the reason

---------

Co-authored-by: James Miller <[email protected]>

Author: seven1m

.github/workflows/specs.yml

@@ -0,0 +1,21 @@
+name: Specs
+on:
+  push:
+    branches: [main]
+  pull_request:
+    branches: [main]
+jobs:
+  run-rspec:
+    runs-on: ubuntu-22.04
+    steps:
+      - name: Checkout code
+        uses: actions/checkout@v2
+      - name: Setup Ruby and install gems
+        uses: ruby/setup-ruby@v1
+        with:
+          ruby-version: 3.1
+          bundler-cache: true
+      - name: Install gems with Appraisal
+        run: bundle exec appraisal install
+      - name: Run RSpec
+        run: bundle exec appraisal rspec

Appraisals

@@ -1,24 +1,3 @@
-appraise "activerecord-4.2" do
-  gem "activerecord", "~> 4.2.0"
-  gem "mysql2", "< 0.5"
-end
-
-appraise "activerecord-5.0" do
-  gem "activerecord", "~> 5.0.0"
-end
-
-appraise "activerecord-5.1" do
-  gem "activerecord", "~> 5.1.0"
-end
-
-appraise "activerecord-5.2" do
-  gem "activerecord", "~> 5.2.0"
-end
-
-appraise "activerecord-6.0" do
-  gem "activerecord", "~> 6.0.2"
-end
-
-appraise "activerecord-master" do
-  gem "activerecord", git: "https://github.com/rails/rails.git"
+appraise "activerecord-7.0" do
+  gem "activerecord", "~> 7.0.0"
 end

CHANGELOG.md

@@ -0,0 +1,52 @@
+## 1.0.0 (unreleased)
+
+- Feature: Add support for Rails 7
+- Change: Drop support for older versions
+- Chore: Test against MySQL 8
+- Fix: Handle ActiveRecord::ConnectionNotEstablished errors too
+- Fix: Do not retry on ActiveRecord::StatementTimeout errors
+
+## 0.5.0 (Jan 29, 2020)
+
+- Change error message for Rails 6.0
+- Load database config from db_config instead
+- Add Active Record 6.0 and master to build matrix
+
+## 0.4.2 (Aug 15, 2018)
+
+- Add activerecord-5.2 test
+- Add error messages accessor
+- Fix mysql2 dependency
+- Added "Connection was killed" as an error string to reconnect on.
+
+## 0.4.1 (Aug 8, 2016)
+
+- Support AR 5.0 (RP#5 @ssig33)
+- Fix test (use docker-compose)
+
+## 0.4.0 (Mar 22, 2016)
+
+- Remove `retryable_transaction`
+- Disable support AR 3.x 4.0
+
+## 0.3.3 (Jan 18, 2014)
+
+- use BigDecimal for sleep
+- add handling error ('The MySQL server is running with the --read-only...')
+
+## 0.3.1 (Jan 9, 2014)
+
+- Retry mode is added
+
+## 0.3.0 (Jan 9, 2014)
+
+- Retry is disabled by default
+- Read-only mode is added
+
+## 0.2.0 (Jan 4, 2014)
+
+- Retry transaction is supported
+
+## 0.1.0 (Oct 11, 2013)
+
+- activerecord-mysql-reconnect is released

ChangeLog

@@ -1,9 +1,8 @@
 # activerecord-mysql-reconnect
 
-It is the library to reconnect automatically when ActiveRecord is disconnected from MySQL.
+Reconnect automatically when ActiveRecord is disconnected from MySQL. Supports Rails 7+ and MySQL 8.
 
-[![Gem Version](https://badge.fury.io/rb/activerecord-mysql-reconnect.svg)](http://badge.fury.io/rb/activerecord-mysql-reconnect)
-[![Build Status](https://travis-ci.org/winebarrel/activerecord-mysql-reconnect.svg?branch=master)](https://travis-ci.org/winebarrel/activerecord-mysql-reconnect)
+[![Specs](https://github.com/planningcenter/activerecord-mysql-reconnect/actions/workflows/specs.yml/badge.svg)](https://github.com/planningcenter/activerecord-mysql-reconnect/actions/workflows/specs.yml)
 
 ## Installation
 

README.md

@@ -18,8 +18,10 @@ Gem::Specification.new do |spec|
   spec.test_files    = spec.files.grep(%r{^(test|spec|features)/})
   spec.require_paths = ['lib']
 
-  # '~> 4.2.6'
-  spec.add_dependency 'activerecord'
+  # We are going to stop using this in Rails 7.1 and beyond in favor of newly
+  # added reconnect / retry functionality. The Platform team will provide
+  # instructions for replacing this gem once 7.1 is released.
+  spec.add_dependency 'activerecord', '~> 7.0.0'
   spec.add_dependency 'mysql2'
   spec.add_development_dependency 'bundler'
   spec.add_development_dependency 'rake'

activerecord-mysql-reconnect.gemspec

@@ -1,6 +1,7 @@
-mysql_for_ar_mysql_reconn:
-  image: "mysql:5.6"
-  ports:
-    - "14407:3306"
-  environment:
-    MYSQL_ALLOW_EMPTY_PASSWORD: "yes"
+services:
+  mysql:
+    image: "mysql:8"
+    ports:
+      - "14407:3306"
+    environment:
+      MYSQL_ALLOW_EMPTY_PASSWORD: "yes"