Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Empty state for sections should consider headers/footers #122

Open
jessesquires opened this issue Jul 9, 2018 · 0 comments
Open

Empty state for sections should consider headers/footers #122

jessesquires opened this issue Jul 9, 2018 · 0 comments

Comments

@jessesquires
Copy link
Contributor

It's possible to have a zero-cell section with only headers and footers. (For both tables and collections)

We should update our definitions of "emptiness" for both models.

Follow-up to #48

Empty means:

  • Zero cells (empty array of *CellViewModels)
  • nil header view
  • nil footer view

Changes needed:

  • Update isEmpty on section models
  • Handle empty sections accordingly. e.g., return 0 in data source methods when appropriate (mostly applies to single-section models)
@jessesquires jessesquires added this to the 0.2.0 milestone Jul 9, 2018
@jessesquires jessesquires self-assigned this Jul 9, 2018
@benasher44 benasher44 modified the milestones: 0.2.0, 0.3.0 Sep 11, 2018
@benasher44 benasher44 modified the milestones: 0.3.0, 0.4.0 Sep 20, 2018
@jessesquires jessesquires removed their assignment Jan 7, 2019
@jessesquires jessesquires modified the milestones: 0.4.0, Next Jan 31, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants