Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Undo Monkey-Spanner Patch and fix ethereumjs-wallet export #35

Open
Akamig opened this issue Jan 20, 2023 · 1 comment
Open

Undo Monkey-Spanner Patch and fix ethereumjs-wallet export #35

Akamig opened this issue Jan 20, 2023 · 1 comment
Assignees
@Akamig
Labels
help wanted Extra attention is needed

Comments

@Akamig
Copy link
Member

Akamig commented Jan 20, 2023

  • 현재는 ESM을 제공한다고 써있기는 한데 사실은 제대로 Export 하고 있지 않다
  • node는 이걸 CommonJS 모듈로 인식하는데 그러면 import 결과 이상하게 나와서 (a.default || a) 해야 한다
  • ESM 빌드 결과 제공하고 Wallet의 named export도 제공하라고 해야한다
  • default export는 죄악이다

https://nodejs.org/dist/latest-v19.x/docs/api/esm.html#import-statements
@Akamig Akamig added the help wanted Extra attention is needed label Jan 20, 2023
@Akamig Akamig self-assigned this Jan 20, 2023
@Akamig
Copy link
Member Author

Akamig commented Jan 20, 2023

Fm4gSvBaAAAZGCo

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Akamig Akamig

Labels
help wanted Extra attention is needed
Projects
Nine Chronicles DX Team
Archived in project
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Akamig