Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle future epoch tx appearing and disappearing when taking partition snapshot #30

Open
area363 opened this issue Jun 14, 2021 · 1 comment
Assignees

Comments

@area363
Copy link
Member

area363 commented Jun 14, 2021

Currently, the snapshot takes care of future epoch tx that's fully established in the main chain.
For example, lets say that our first snapshot file is snapshot-1-1.zip. On the next snapshot schedule, if the current epoch is 1 and a future tx in epoch 3 exists, snapshot-1-3.zip will be created. If the future tx still remains in the next snapshot schedule, snapshot-1-3.zip will be created again. However, if for some reason the future tx disappears, snapshot-1-1.zip will be created and this will overwrite the original snapshot-1-1.zip. This will contaminate the snapshot file download order in the metadata and needs a fix.

@area363 area363 self-assigned this Jun 14, 2021
@area363
Copy link
Member Author

area363 commented Jun 14, 2021

For a quick fix, snapshot will be adjusted to take 100 blocks before the preloaded chain tip (confirmation: 1).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant