Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change action check logic from multi if to if-else/switch #666

Open
U-lis opened this issue Apr 1, 2024 · 1 comment
Open

Change action check logic from multi if to if-else/switch #666

U-lis opened this issue Apr 1, 2024 · 1 comment
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@U-lis
Copy link
Contributor

U-lis commented Apr 1, 2024

We're now creating data in MySqlMigration.cs.
As seeing action type check logic (From Line 388), there are a bunch of if statements are present and every action data goes through all if statesments.
But one data cannot be two type of actions at the same time, so we can optimize it by changing if-s to if-else of switch statement.

Furthermore, we can optimize it once more by aligning actions by frequency (e.g., check HAS first, DailyReward next, and so on).

@U-lis U-lis added enhancement New feature or request good first issue Good for newcomers labels Apr 1, 2024
@dhrisyadas
Copy link

Hi can this issue be still worked on?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
Status: Todo
Development

No branches or pull requests

2 participants