-
-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
suport multiple basic/bearer credentials for 'Authorization' server support #352
Comments
Hi @GlenDC, I'd like to take this one up. I'm new to the codebase and fairly new to Rust though. |
hi @npalladium . All yours.
Next to that, feel free to open a PR whenever you are stuck, need help, guidance or anything else. Ask here also questions or provide feedback as you see fit. Welcome to the rama repo and I hope to see you around! :) |
Hi @GlenDC. I think the requirements are clear. I'm looking at the adjacent code right now. I hope to have a draft PR ready sometime tomorrow. I'll let you know in the PR or on this issue if I need any help. |
Sounds great. Do feel free to open the PR even if it doesn't compile, in case you have questions, feedback or in need of help in general. Thanks for your valued time and contribution! |
Hi @npalladium I wanted to check in with you to see how you are doing. If there's guidance you need or have questions, do feel free to ask. |
Hi @GlenDC, I'm still interested. I think I'll try to open a PR this week, asking for help as required. Assuming that timeline works for you. Let me know. More info: I dropped the ball on this one and I'm sorry about that. Life got in the way and I couldn't get back on this. Thanks for checking in. |
That works just fine @npalladium. Also if you do ever want to just back off in resolving this ticket that's also ok. This is purely a voluntary thing that you would hopefully do because at the very least you enjoy it. No hard feelings if you want to therefore ever drop the ball for real on it. Also no justification needed :) Life is life, I get it. Thanks for coming back to, happy to have you onboard as well. Take care either way. All best to you. |
We already have support for this header for a single
Basic
/Bearer
credential as can be found in https://github.com/plabayo/rama/blob/main/rama-http/src/layer/auth/require_authorization.rs.Goal of this issue is to:
[Basic; N]
,Vec<Basic>
,[Bearer; N]
andVec<Bearer>
;Arc<...>
supportIn order to support this all it is probably easiest to refactor the code a bit by:
Basic
,Bearer
,Vec<impl Authorizer>
,[impl Authorizer; N]
,Arc<Authorizer>
.This way you only need a single implementation of the actual authorize/anonymouse logic as the actual authorization validation can be done by the
Authorizer
trait.This issue is low priority, but due to a contribution from someone recently I noticed that we don't have support for multiple credentials here yet, while we do have that support for Proxy-Authorization. Mentorship is available for this one.
The text was updated successfully, but these errors were encountered: