-
-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support ICAP (RFC-3507) #339
Comments
https://github.com/chills42/icaparse can serve as inspiration |
I'm interested in this and just made an draft PR. Could you assign me? I'd also like to clarify the scope of initial support. |
Sure thing, all yours. I can see you already started with it, so it gives me hope. Know though that this wasn't marked as mentor available. That doesn't mean I cannot guide, help or anything like that, but it more means that I assume you are pretty good at programming and can independently get most of the way there. Some requirements for this crate are:
There is a lot of similarities with HTTP/1 so can see if there is stuff/code/ideas that can be borrowed from rama-http-core h1 proto code. The deliverables in order to close this ticket are:
E.g. the example can be
However in case your PR only implements the protocol layer with sufficient tests and some simple integration tests showcasing the server client then that is already good enough to start it as well. The core protocol server and client are unrelated from a rama service/layer. They are just stuff on their own. Next to this (in this PR or a follow up PR) a layer service will be added that wraps the client, so that one can easily send passing http traffic via an ICAP server given by the client in that layer. This is a pretty big task though, so take it as far as you can, so for the sake of the quality of your work might not want to overdo the scope of your PR as to make sure you have the will, energy and motivation to deliver the stuff that you did do with pride and quality. I'm here for you for feedback, guidance or anything else. Given this work became a lot more priority for some people I might take over in a week or two should this not progress fast enough. That wouldn't say anything about you though, its just that I do need it at some point soon. Until then however I have plenty of other stuff that I can still do myself. So also don't stress on it. |
Add initial support for ICAP.
Once we have this we can look into what else related to ICAP we need.
RFC: https://www.rfc-editor.org/rfc/pdfrfc/rfc3507.txt.pdf
The text was updated successfully, but these errors were encountered: