Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

muted sites gets forgotten every time firefox is closed. #3

Open
revoconner opened this issue Oct 1, 2024 · 1 comment
Open

muted sites gets forgotten every time firefox is closed. #3

revoconner opened this issue Oct 1, 2024 · 1 comment
Labels
enhancement New feature or request

Comments

@revoconner
Copy link

Can we keep a temp file that writes the state of mute so that sites once muted never gets unmuted?

@pkrasicki
Copy link
Owner

I think that might be confusing to users. Normally when you mute a tab in Firefox, the action will not persist after restart. On the other hand, Chromium has a built-in mute site feature and I'm not sure how it works there. If it is persistent, then maybe it would make sense to do the same here - if it's not weird to Chromium users, then it might be ok.

A compromise could be to add an optional setting that a user could enable (it would be disabled by default) to remember muted sites. That way users wouldn't be confused about what's happening. And since it would be disabled by default, I wouldn't have to worry about changing the behaviour for existing users, which might be confusing to them (do Firefox addons auto update without informing the user? I can't remember).

Another issue is that if we do this (either by default or with the setting), we would probably have to add some way to view and manage a list of all those permanently muted sites and there already are other extensions for that. This one was supposed to be simple, convenient and easy to use.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants