Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API for retrieving submission files with Reviewer role #9964

Open
jardakotesovec opened this issue May 16, 2024 · 1 comment
Open

API for retrieving submission files with Reviewer role #9964

jardakotesovec opened this issue May 16, 2024 · 1 comment
Assignees
Labels
Enhancement:2:Moderate A new feature or improvement that can be implemented in less than 4 weeks.
Milestone

Comments

@jardakotesovec
Copy link
Contributor

Describe the issue

While working on new #7495. Having reviewer role I need to be able to see submission files that are assigned for review.

Per my understanding these files would have fileStage=4 (SUBMISSION_FILE_REVIEW_FILE) and would be associated via reviews_files, because available files can be cherry picked when assigning reviewer.

Proposed solution
It seems reasonable to be able to retrieve these files from existing endpoint

api/v1/submissions/10/files?fileStages=4&reviewRoundId=8

Currently I don't get access to this endpoint at all as reviewer.

But maybe additionally pass reviewAssignmentId or reviewId? As there should be explicit information that it needs to be for that particular review.

What application are you using?
OJS, OMP or OPS version 3.5

@jardakotesovec jardakotesovec added the Enhancement:2:Moderate A new feature or improvement that can be implemented in less than 4 weeks. label May 16, 2024
@jardakotesovec jardakotesovec added this to the 3.5.0 LTS milestone May 16, 2024
@ewhanson
Copy link
Collaborator

There are still some things being sorted out, but this is quite similar to #9963 and could generally follow the same pattern/approach I suspect.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement:2:Moderate A new feature or improvement that can be implemented in less than 4 weeks.
Projects
None yet
Development

No branches or pull requests

4 participants