Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rework core API #102

Closed
pkosiec opened this issue Dec 24, 2019 · 5 comments
Closed

Rework core API #102

pkosiec opened this issue Dec 24, 2019 · 5 comments
Labels
area/core Refers to Mongo Seeding library 🚀 enhancement New feature or request
Milestone

Comments

@pkosiec
Copy link
Owner

pkosiec commented Dec 24, 2019

In near future, I would like to rewrite Mongo Seeding core. It may introduce some breaking changes, as I want to support additional features, without making the API too complex.

While rethinking API, I want to consider the following abilities:

@pkosiec pkosiec added 🚀 enhancement New feature or request area/core Refers to Mongo Seeding library labels Dec 24, 2019
@pkosiec pkosiec added this to the 4.0.0 milestone Dec 24, 2019
@pkosiec pkosiec added this to To Do in Mongo Seeding via automation Dec 24, 2019
@khawarizmus
Copy link

First of all thank you for this amazing tool.

I am currently missing mongoose support. any idea of when that gonna land?

@pkosiec
Copy link
Owner Author

pkosiec commented Nov 14, 2020

Hi @gimyboya,
Thanks for very kind words 🙂
Unfortunately I can't tell precisely when the Mongo Seeding will land. It's a huge change and I want to start with API redesign. However, currently I don't have that much time to implement such big changes. Hopefully I will be able to work on that next year, but can't promise that 😞

@pkosiec pkosiec moved this from To Do to Backlog in Mongo Seeding Nov 16, 2020
@yharaskrik
Copy link

Hey @pkosiec if there was some kind of spec of how you want the core to be designed maybe we could contribute to it, my company uses your library for all of our APIs e2e tests but would love a way to specify custom tsconfigs and support for more than just a single export. Would be happy to contribute if possible! Would make our lives quite a bit easier!

@pkosiec
Copy link
Owner Author

pkosiec commented Jan 22, 2021

Hi @yharaskrik! Thank you, I really appreciate that.

Currently I don't have any specification nor time to design a new API 😞 I would like to rewrite Mongo Seeding, as I see a huge room for improvement when it comes to API and also code quality. But I'll be honest with you: I didn't use MongoDB from a long period of time. Also, TypeScript is not my primary language from a few years now. That's why the motivation for complete rewrite of Mongo Seeding is low - I think it's understandable if I don't use Mongo Seeding by myself.

But! It doesn't mean Mongo Seeding is going to be archived or unmaintained anytime soon - no, I still like to develop some features, as long as they don't consume much time for me.

Regarding contribution: sure, I'm open for any contribution 🙂 To ensure the ideas for new features are discussed and accepted, please always start from creating an issue before actual implementation.

I would like to hear more about your ideas for the features. Could you please elaborate bit about them?

would love a way to specify custom tsconfigs

Hmm, but that should be supported out of the box 🤔 ts-node loads the tsconfig.json automatically, similarly to tsc: https://github.com/TypeStrong/ts-node#loading-tsconfigjson

support for more than just a single export

Do you mean the support for multiple exports (named exports) in TypeScript data import files? Or something else?

It would be great if you could open brand-new issues (one per feature idea) to make our discussion more visible for others. Thanks a lot!

@pkosiec pkosiec modified the milestones: 4.0.0, Future Sep 28, 2022
@pkosiec
Copy link
Owner Author

pkosiec commented Dec 9, 2023

Closing this issue for now as major API changes are not planned unless there's a specific feedback from the community 🙂

@pkosiec pkosiec closed this as not planned Won't fix, can't repro, duplicate, stale Dec 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/core Refers to Mongo Seeding library 🚀 enhancement New feature or request
Projects
Status: Done
Mongo Seeding
  
Backlog
Development

No branches or pull requests

3 participants