Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Link the current branch/commit, rather than default branch #83

Closed
dominykas opened this issue Feb 23, 2021 · 1 comment · Fixed by #85
Closed

Link the current branch/commit, rather than default branch #83

dominykas opened this issue Feb 23, 2021 · 1 comment · Fixed by #85
Assignees
@dominykas
Labels
released

Comments

@dominykas
Copy link
Member

dominykas commented Feb 23, 2021 •
edited
Loading

At the moment, wiby test will link the sha of the master into the dependents.

It should instead link the branch that it's running against. Possibly try to detect the branch using env-ci if it's running on a detached head.

I'll fix this together with #78 - just documenting the issue.
@dominykas dominykas self-assigned this Feb 23, 2021
@dominykas dominykas changed the title Link the current branch/commit, rather than against master Link the current branch/commit, rather than default branch Feb 23, 2021
@dominykas dominykas mentioned this issue Mar 18, 2021
Merged
@dominykas
Copy link
Member Author

🎉 This issue has been resolved in version 0.5.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dominykas dominykas

Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Name wiby test branches based on the dependency branch name pkgjs/wiby
1 participant
@dominykas