Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wiby clean command #79

Closed
dominykas opened this issue Jan 31, 2021 · 3 comments · Fixed by #81
Closed

wiby clean command #79

dominykas opened this issue Jan 31, 2021 · 3 comments · Fixed by #81
Assignees
Labels

Comments

@dominykas
Copy link
Member

At the moment, wiby test creates a branch called wiby-[dep name] in the dependent repos. There is nothing to clean this up - running a new wiby test will fail if the branch already exists.

wiby test should not fail on existing branch - but that is a separate, larger problem (I'll create a separate issue), but in the meantime - deleting the wiby-wiby branch manually on wiby-test/* repos is a hassle during development.

wiby clean should take the following options:

  • --all - remove all wiby-* branches (by default only remove the current branch, based on the naming as proposed in Name wiby test branches based on the dependency branch name #78)
  • --dry-run - show the branches that would be removed
    • alternative: do the dry-run by default and ask the user to confirm the action? With an optional --force to skip the confirmation?
    • bonus points: what if the branches contain commits other than ones made by wiby?
@dominykas dominykas self-assigned this Jan 31, 2021
@ghinks
Copy link
Contributor

ghinks commented Feb 22, 2021

I"ll have a look at this if you are not already doing so?

@dominykas
Copy link
Member Author

dominykas commented Feb 22, 2021

I'm almost done with this, will likely PR today (or this week).

@dominykas
Copy link
Member Author

🎉 This issue has been resolved in version 0.3.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants