Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bug: pnpm to detect which version to use #29

Open
privatenumber opened this issue Apr 7, 2021 · 2 comments
Open

bug: pnpm to detect which version to use #29

privatenumber opened this issue Apr 7, 2021 · 2 comments

Comments

@privatenumber
Copy link
Member

Bug description

Running pnpm i --frozen-lock with the latest pnpm can fail if the lock was made by a different version (eg. pnpm 6 with pnpm 5 lock).

Should read pnpm version from yaml file instead.

Reproduction steps

Environment

  • pkg-size-action version:
  • Operating System:
  • Node version:
@privatenumber
Copy link
Member Author

Actually, this might've been a misunderstanding of the error. But pnpm 6 only supports Node 12+ so if it fails, the error should be clear.

@privatenumber
Copy link
Member Author

Can be fixed with the new https://github.com/privatenumber/ci

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@privatenumber