Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Added deleting a form feature #41

Closed

Conversation

sujayshanbhag
Copy link

What does this PR do?

This PR adds a feature to delete forms on the backend. I have created a 'deleteForm' mutation and made changes to the services/form as well.

Fixes #40
image

Type of change

  • New feature (non-breaking change which adds functionality)

How should this be tested?

  • What are the minimal test data to have?
    Needs at least one project and one form in said project to be created locally. So that it can be deleted.
  • What is expected (happy path) to have (input and output)?
    1. For the query to return true.
    2. The deleted form to not exist when queried

Mandatory Tasks

  • Make sure you have self-reviewed the code. A decent size PR without self-review might be rejected.

Checklist

  • I haven't added tests that prove my fix is effective or that my feature works
  • I haven't checked if new and existing unit tests pass locally with my changes

@github-actions
Copy link

github-actions bot commented Oct 10, 2023

Thank you for following the naming conventions! 🙏

@sujayshanbhag sujayshanbhag changed the title Added deleting a form feature feat: Added deleting a form feature Oct 10, 2023
@sujayshanbhag
Copy link
Author

Hey there @piyushgarg-dev, if any changes required I'm happy to make them. Thanks for this opportunity.

@MrPKJ
Copy link

MrPKJ commented Oct 16, 2023

Why still this PR not merged?

@MrPKJ
Copy link

MrPKJ commented Oct 16, 2023

@sujayshanbhag How can I access your updated repo so that I can fix the deleting form issue in frontend.

@sujayshanbhag
Copy link
Author

@sujayshanbhag How can I access your updated repo so that I can fix the deleting form issue in frontend.

You'll have to wait until its merged in the main branch. And I'd like to integrate this feature in the frontend as well. So can you please find some other issue?

@github-actions
Copy link

Hey there, there is a merge conflict, can you take a look?

@github-actions github-actions bot added the 🚨 merge conflict Merge Conflict label Oct 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🚨 merge conflict Merge Conflict
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add deleting a form feature
2 participants