-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug: Sidebar activation body is sometimes missing #8965
Comments
The mod in question is a 1-click wonder (doesn't have any activation options), so it shouldn't be showing the activation form (Cancel/OK) https://www.pixiebrix.com/marketplace/31013451-a9ed-4d1f-9cc0-f869ceb767be/ What might be happening is there's an error fetching some data (the marketplace listing?) causing some of the Code Reference:
|
It's not an error, and this component isn't a 1-click wonder. The css file is being disabled by IsolatedComponent: When the bug is replicated:When the sidebar renders as expected:Note the difference for Looks to be a race condition that is only reproducible if there is another panel open See pixiebrix-extension/src/components/IsolatedComponent.tsx Lines 39 to 70 in b270af7
|
* fix sidebar activation body sometimes missing * use allowlist * explain cssFileAllowList wiht comment
Describe the bug
The body of the sidebar mod activation panel is sometimes missing, despite the elements being present in the DOM:
To Reproduce
Unfortunately, there is not a reliable way to reproduce. But it happens after:
Actual behavior
Sidebar shows only the CTA buttons, and no sidebar activation panel body, despite the body being present in the DOM.
Expected behavior
Sidebar panel is fully-populated with sidebar activation copy/mod configuration options.
Additional context
pixiebrix-extension/src/utils/layout.scss
Lines 87 to 90 in 5bb2c66
The text was updated successfully, but these errors were encountered: