Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the hack for iframes using srcdoc + sandbox #8951

Open
fungairino opened this issue Jul 29, 2024 · 0 comments
Open

Remove the hack for iframes using srcdoc + sandbox #8951

fungairino opened this issue Jul 29, 2024 · 0 comments
Labels
blocked For denoting when an issue is blocked by an external dependency (ex. zendesk) developer experience

Comments

@fungairino
Copy link
Collaborator

fungairino commented Jul 29, 2024

Currently we use a hack to remove the sandbox attribute from iframes that use the srcdoc and sandbox attribute in order for our content script to be properly injected into the frame. For more context on the hack, see: #8927 and https://pixiebrix.slack.com/archives/C07DQ2J7C78

Ideally we could just enable "match_origin_as_fallback": true for our content script configuration in the manifest.json, but we run into a chromium bug regarding dynamic imports within a sandbox frame.

This issue tracks removing the above-mentioned hack once the related chromium issues have been fixed:
https://issues.chromium.org/issues/355256366
https://issues.chromium.org/issues/40564567

The related end-to-end test should still pass once this hack is removed.

test("8143: mods can run in srcdoc iframes", async ({

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocked For denoting when an issue is blocked by an external dependency (ex. zendesk) developer experience
Projects
None yet
Development

No branches or pull requests

1 participant