Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Spike] Research scope of updating React-Bootstrap to v5 #8913

Open
grahamlangford opened this issue Jul 23, 2024 · 3 comments
Open

[Spike] Research scope of updating React-Bootstrap to v5 #8913

grahamlangford opened this issue Jul 23, 2024 · 3 comments
Labels

Comments

@grahamlangford
Copy link
Collaborator

Motivation

  • We hypothesize that upgrading would simplify theming
  • Find out the basic LOE for the upgrade
  • We should consider how this impacts the Form Builder

Notes

  • Timebox to 2-4 hours
@grahamlangford
Copy link
Collaborator Author

@mnholtz please add any other context as you see fit

Copy link

This issue will be closed in 7 days unless the stale label is removed, or a comment is added to the issue.

@github-actions github-actions bot added the Stale label Oct 22, 2024
@mnholtz
Copy link
Collaborator

mnholtz commented Oct 22, 2024

After upgrading to Bootstrap 5 in the www project, I identified that migrating over utility classes is trivial, but verifying visual regression is non-trivial. I still think this will be valuable to look into (and will keep this on my 30% time radar) due to deprecations in sass 1.80.0 which I'm not sure if Bootstrap 4 will support (we'll have to keep an eye on that). See this ticket here: https://github.com/pixiebrix/pixiebrix-www/pull/1122

@mnholtz mnholtz removed the Stale label Oct 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants