Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A11Y and label issues with switch component #8879

Open
fungairino opened this issue Jul 18, 2024 · 2 comments
Open

A11Y and label issues with switch component #8879

fungairino opened this issue Jul 18, 2024 · 2 comments
Labels
bug Something isn't working testing user experience Improve the user experience (UX)

Comments

@fungairino
Copy link
Collaborator

fungairino commented Jul 18, 2024

Describe the bug

  • The switch component we use for forms and other isolated controls has a few issues (we use BootstrapSwitchButton)
    • The switch is not focusable. I.e. you can't tab into it and can't toggle it with enter/space
    • The switch is not labelled properly. I.e. the label next to it is not connected properly to it as a form control. (i.e. the label element for` does not point to anything)
      • If it were labelled properly, it would be selectable/focusable if you clicked on the label, and it would be queryable by external locators (i.e. playwright findByLabel)

Screenshots/Loom

Recording: https://www.loom.com/share/d66e6da1133b44a8a19f49a2334e2a63

Code refs


https://github.com/pixiebrix/pixiebrix-extension/blob/main/end-to-end-tests/pageObjects/basePageObject.ts#L98-L101

@fungairino fungairino added bug Something isn't working testing labels Jul 18, 2024
@twschiller twschiller added the user experience Improve the user experience (UX) label Jul 18, 2024
Copy link

This issue will be closed in 7 days unless the stale label is removed, or a comment is added to the issue.

@github-actions github-actions bot added the Stale label Oct 17, 2024
Copy link

This issue was closed because it has been stale for 7 days with no activity.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Oct 24, 2024
@fungairino fungairino reopened this Oct 24, 2024
@github-actions github-actions bot removed the Stale label Oct 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working testing user experience Improve the user experience (UX)
Projects
None yet
Development

No branches or pull requests

2 participants