Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sidebar panels not updated when moving/packaging sidebar mod components #8872

Closed
BLoe opened this issue Jul 17, 2024 · 2 comments
Closed

Sidebar panels not updated when moving/packaging sidebar mod components #8872

BLoe opened this issue Jul 17, 2024 · 2 comments
Labels
bug Something isn't working page editor Stale user experience Improve the user experience (UX)

Comments

@BLoe
Copy link
Contributor

BLoe commented Jul 17, 2024

Describe the bug

When working with sidebar mod components in the page editor, there are a number of odd, unintuitive behaviors that happen when moving components into and out of mods, as well as some cases of copying the components.

For example:

Create a new mod component, add it to a mod, and choose to "create a new mod" when adding the component

https://www.loom.com/share/5cb0fa3107774c39ba8968f5105496c8

Copy a freshly created mod component into an existing mod

https://www.loom.com/share/975be15851984a68b6963fd7e92240e5


These problems are most likely caused by race conditions and sub-optimal logic within the communication between the page editor, the content script ("sidebar controller"), and the sidebar app. The complexity of the code architecture, in terms of sidebar panels and the page editor, makes investigating these issues much more difficult and time-consuming, due to the amount of scope required to grok the whole end-to-end data flow in the app(s).

@BLoe BLoe added the bug Something isn't working label Jul 17, 2024
@twschiller twschiller changed the title As a mod developer, when I am building sidebar mods, I expect consistent, predictable behavior from the sidebar app UI Sidebar available panels not updated when moving/packaging sidebar mod components Jul 18, 2024
@twschiller twschiller changed the title Sidebar available panels not updated when moving/packaging sidebar mod components Sidebar panels not updated when moving/packaging sidebar mod components Jul 18, 2024
@twschiller twschiller added page editor user experience Improve the user experience (UX) labels Jul 18, 2024
Copy link

This issue will be closed in 7 days unless the stale label is removed, or a comment is added to the issue.

@github-actions github-actions bot added the Stale label Oct 17, 2024
Copy link

This issue was closed because it has been stale for 7 days with no activity.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Oct 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working page editor Stale user experience Improve the user experience (UX)
Projects
None yet
Development

No branches or pull requests

2 participants