Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extension Console integrations: Zapier modal cannot be closed #7756

Closed
fregante opened this issue Feb 28, 2024 · 5 comments · Fixed by #8633
Closed

Extension Console integrations: Zapier modal cannot be closed #7756

fregante opened this issue Feb 28, 2024 · 5 comments · Fixed by #8633
Assignees
Labels
bug Something isn't working triage user experience Improve the user experience (UX)

Comments

@fregante
Copy link
Contributor

Describe the bug

You can open it, but it stays open until a page reload

To Reproduce

Steps to reproduce the behavior:

  1. Go to chrome-extension://mpjjildhmpddojocokjkgmlkkkfjnepo/options.html#/services
  2. Click on "View key" next to Zapier
  3. Click "x" button

Actual behavior

Nothing happens, no errors in console. Even when clicking outside or pressing ESC.

Only the URL changes from #/services/zapier/ to #/services/

Screenshots/Loom

Screenshot 15

Desktop (please complete the following information):

  • Extension Version: 1.8.10-local
@fregante fregante added the bug Something isn't working label Feb 28, 2024
@fregante
Copy link
Contributor Author

fregante commented Feb 28, 2024

Related URL bug

If you open chrome-extension://mpjjildhmpddojocokjkgmlkkkfjnepo/options.html#/services/zapier/ directly:

  • the modal doesn't open
  • the View Key button doesn't do anything

I vote to just drop this deep-link

@brittanyjoiner15
Copy link
Collaborator

Upvoting this since I came across a user that hit it last week

@twschiller twschiller added the user experience Improve the user experience (UX) label Jun 16, 2024
@twschiller twschiller self-assigned this Jun 16, 2024
@twschiller
Copy link
Contributor

twschiller commented Jun 16, 2024

@brittanyjoiner15 is this still happening for you? I'm not able to reproduce either problem locally or on the CWS version

Note that "esc" doesn't work, you have to click the "x"

I've created a PR with a Playwright test verifying the behavior: #8633

@brittanyjoiner15
Copy link
Collaborator

@twschiller interesting, not happening for me anymore either. must've gotten fixed with something at some point!

@BLoe
Copy link
Contributor

BLoe commented Jun 17, 2024

I don't remember the specific PR but I think I may have fixed this at some point... 🤔

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working triage user experience Improve the user experience (UX)
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants